From: "Johannes Löthberg" <johannes@kyriasis.com>
To: git@vger.kernel.org
Subject: Re: GitHub Pull Request merge commands
Date: Tue, 16 Jun 2015 11:33:45 +0200 [thread overview]
Message-ID: <20150616093345.GA28617@leeloo.kyriasis.com> (raw)
In-Reply-To: <mloo9l$agl$6@ger.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On 16/06, Florian Lindner wrote:
>My question is, if davidsblom make further commits to his develop branch
>(after the pull request was issued) aren't these commits also included in
>the pull and therefore in the merge? If yes, isn't the idea to merge just
>the changes that the pull request was about? If not, why? ;-)
>
A pull request is "about" all commits in the branch, which is why
topic-branches should be used for PRs.
--
Sincerely,
Johannes Löthberg
PGP Key ID: 0x50FB9B273A9D0BB5
https://theos.kyriasis.com/~kyrias/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1495 bytes --]
prev parent reply other threads:[~2015-06-16 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 8:55 GitHub Pull Request merge commands Florian Lindner
2015-06-16 9:33 ` Johannes Löthberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616093345.GA28617@leeloo.kyriasis.com \
--to=johannes@kyriasis.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox