From: Jeff King <peff@peff.net>
To: Mike Edgar <adgar@google.com>
Cc: git@vger.kernel.org, pclouds@gmail.com
Subject: Re: [PATCH v2] fetch-pack: check for shallow if depth given
Date: Wed, 17 Jun 2015 13:00:01 -0400 [thread overview]
Message-ID: <20150617170001.GC22689@peff.net> (raw)
In-Reply-To: <1434541694-12748-1-git-send-email-adgar@google.com>
On Wed, Jun 17, 2015 at 07:48:14AM -0400, Mike Edgar wrote:
> When a repository is first fetched as a shallow clone, either by
> git-clone or by fetching into an empty repo, the server's capabilities
> are not currently consulted. The client will send shallow requests even
> if the server does not understand them, and the resulting error may be
> unhelpful to the user. This change pre-emptively checks so we can exit
> with a helpful error if necessary.
>
> Signed-off-by: Mike Edgar <adgar@google.com>
Looks good to me.
-Peff
next prev parent reply other threads:[~2015-06-17 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 18:35 [PATCH] clone: check if server supports shallow clones Mike Edgar
2015-06-10 19:05 ` Jeff King
2015-06-10 20:25 ` Michael Edgar
2015-06-10 20:56 ` Jeff King
2015-06-11 13:02 ` Duy Nguyen
2015-06-11 14:32 ` Jeff King
2015-06-11 18:18 ` Michael Edgar
2015-06-11 20:44 ` Junio C Hamano
2015-06-17 11:48 ` [PATCH v2] fetch-pack: check for shallow if depth given Mike Edgar
2015-06-17 17:00 ` Jeff King [this message]
2015-06-17 16:35 ` [PATCH] clone: check if server supports shallow clones Junio C Hamano
2015-06-17 16:59 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2015-06-18 0:31 [PATCH v2] fetch-pack: check for shallow if depth given Mike Edgar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617170001.GC22689@peff.net \
--to=peff@peff.net \
--cc=adgar@google.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).