From: Jeff King <peff@peff.net>
To: Richard Hansen <rhansen@bbn.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo
Date: Wed, 17 Jun 2015 18:13:31 -0400 [thread overview]
Message-ID: <20150617221331.GA26069@peff.net> (raw)
In-Reply-To: <1434575481-24604-3-git-send-email-rhansen@bbn.com>
On Wed, Jun 17, 2015 at 05:11:21PM -0400, Richard Hansen wrote:
> + test -z "$1" && test -n "$quiet" && return
> + eval "say_color_color=\$say_color_$1"
Thanks, this looks much simpler.
In the non-quiet case, you will eval $say_color_, even though we know it
to be bogus. I guess we need to make sure say_color_color is blank,
though. The alternative would be:
if test -z "$1"; then
test -n "$quiet" && return
say_color_color=
else
eval "say_color_color=\$say_color_$1"
fi
I dunno if that makes the intent more clear or not. I am OK with it
either way.
-Peff
next prev parent reply other threads:[~2015-06-17 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 19:06 [PATCH 0/2] redo fix for test-lib.sh color support Richard Hansen
2015-06-17 19:06 ` [PATCH 1/2] Revert "test-lib.sh: do tests for color support after changing HOME" Richard Hansen
2015-06-17 19:06 ` [PATCH 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo Richard Hansen
2015-06-17 19:43 ` Jeff King
2015-06-17 19:55 ` Richard Hansen
2015-06-17 20:15 ` Junio C Hamano
2015-06-17 21:11 ` [PATCH v2 0/2] redo fix for test-lib.sh color support Richard Hansen
2015-06-17 21:11 ` [PATCH v2 1/2] Revert "test-lib.sh: do tests for color support after changing HOME" Richard Hansen
2015-06-17 21:11 ` [PATCH v2 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo Richard Hansen
2015-06-17 22:13 ` Jeff King [this message]
2015-06-17 22:23 ` Junio C Hamano
2015-06-17 22:26 ` Jeff King
2015-06-17 20:25 ` [PATCH " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617221331.GA26069@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rhansen@bbn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).