From: "Johannes Löthberg" <johannes@kyriasis.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] upload-pack: Fail if cloning empty namespace
Date: Sat, 20 Jun 2015 16:27:45 +0200 [thread overview]
Message-ID: <20150620142705.GA23163@leeloo.kyriasis.com> (raw)
In-Reply-To: <xmqqh9q87l3x.fsf@gitster.dls.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On 15/06, Junio C Hamano wrote:
>You would probably want new tests, but more importantly did you make
>sure this passes existing tests? It seems to break 5509 (there
>could be others) at least for me.
>
It breaks 5509 currently yeah, though I've already fixed it locally.
Anyway,
You create a namespace by pushing to it, and without a HEAD the
namespace is not a proper repo, and the code won't deal with them
properly. (Which is why without that patch this patch is useless.)
So, if you don't want HEAD to be created when pushing to a ref
namespace, (which seems to be what you're leaning toward, considering
your last reply to the other thread,) then ref namespaces won't really
work in most cases, and it seems pointless to support them at all.
--
Sincerely,
Johannes Löthberg
PGP Key ID: 0x50FB9B273A9D0BB5
https://theos.kyriasis.com/~kyrias/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1495 bytes --]
next prev parent reply other threads:[~2015-06-20 14:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 20:15 [PATCH/RFC] upload-pack: Fail if cloning empty namespace Johannes Löthberg
2015-06-12 21:01 ` Junio C Hamano
2015-06-12 22:17 ` [PATCH v2] " Johannes Löthberg
2015-06-12 22:32 ` Johannes Löthberg
2015-06-15 20:49 ` Junio C Hamano
2015-06-20 14:27 ` Johannes Löthberg [this message]
2015-06-20 18:06 ` Junio C Hamano
2015-06-20 18:13 ` Johannes Löthberg
2015-06-20 21:20 ` Junio C Hamano
2015-06-20 21:49 ` Johannes Löthberg
2015-06-21 18:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150620142705.GA23163@leeloo.kyriasis.com \
--to=johannes@kyriasis.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).