From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git <git@vger.kernel.org>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Thomas Ferris Nicolaisen <tfnico@gmail.com>,
Nicola Paolucci <npaolucci@atlassian.com>
Subject: Re: Draft of Git Rev News edition 5
Date: Mon, 6 Jul 2015 15:39:41 -0400 [thread overview]
Message-ID: <20150706193941.GA1730@flurp.local> (raw)
In-Reply-To: <xmqqfv5118a3.fsf@gitster.dls.corp.google.com>
On Mon, Jul 06, 2015 at 10:54:28AM -0700, Junio C Hamano wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > How about this instead: prefixing with "As originally implemented",
> > with a couple s/is/was/ thrown in...
> >
> > As originally implemented, creation of linked-worktrees was
> > accomplished via `git checkout --to <path> <branch>`, and cleanup
> > of leftover administrative files, after `<path>` is deleted, was
> > done with `git prune --worktrees`. However, a recent unrelated
> > change to `git prune` led to a discussion that concluded that
> > worktree-related maintenance functionality didn't belong in `git
> > prune`.
> >
> > Is that sufficient to clue in the reader that "checkout --to" is not
> > final form,...
>
> Yeah, I think that is a good way to address my concern.
>
> The current draft release notes to 2.5 mentions this feature as
> experimental and warns that its UI is bound to change. We will
> ship the upcoming release with "checkout --to" and the more places
> we advise the users that this UI is not final, the better.
Here it is in patch form. (I wouldn't be surprised if the non-ASCII
characters in Duy's name in the context line get botched again...)
---- 8< ----
From: Eric Sunshine <sunshine@sunshineco.com>
Subject: [PATCH] rn-5: make it clear that "git checkout --to" is not final
form
We don't want to mislead reader who is only lightly skimming the text
or who doesn't read the entire article that "git checkout --to" is the
final form.
---
rev_news/drafts/edition-5.md | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/rev_news/drafts/edition-5.md b/rev_news/drafts/edition-5.md
index 241e9df..b71c99c 100644
--- a/rev_news/drafts/edition-5.md
+++ b/rev_news/drafts/edition-5.md
@@ -35,12 +35,13 @@ Unix-only and somewhat fragile `contrib/git-new-workdir` script,
linked-worktrees recently migrated to the *master* branch, but is not
yet part of any release.
-Creation of linked-worktrees is accomplished via `git checkout --to <path>
-<branch>`, and cleanup of leftover administrative files, after `<path>` is
-deleted, is done with `git prune --worktrees`. However, a recent unrelated
-change to `git prune` led to a
+As originally implemented, creation of linked-worktrees was accomplished
+via `git checkout --to <path> <branch>`, and cleanup of leftover
+administrative files after manual deletion of `<path>` was done with `git
+prune --worktrees`. However, a recent unrelated change to `git prune` led
+to a
[discussion](http://thread.gmane.org/gmane.comp.version-control.git/272447/focus=272546)
-that concluded that worktree-related maintenance functionality doesn't
+that concluded that worktree-related maintenance functionality didn't
belong in `git prune`.
Consequently, Nguyễn Thái Ngọc Duy submitted a
--
2.5.0.rc1.197.g417e668
next prev parent reply other threads:[~2015-07-06 19:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 11:13 Draft of Git Rev News edition 5 Christian Couder
2015-07-05 19:11 ` Eric Sunshine
2015-07-05 21:13 ` Christian Couder
2015-07-05 22:01 ` Eric Sunshine
2015-07-05 22:35 ` Thomas Ferris Nicolaisen
2015-07-05 23:12 ` Eric Sunshine
2015-07-08 7:22 ` Michael J Gruber
2015-07-08 7:43 ` Junio C Hamano
2015-07-08 10:29 ` Christian Couder
2015-07-08 13:02 ` Johannes Schindelin
2015-07-08 17:36 ` Junio C Hamano
2015-07-06 16:38 ` Junio C Hamano
2015-07-06 17:24 ` Eric Sunshine
2015-07-06 17:54 ` Junio C Hamano
2015-07-06 19:39 ` Eric Sunshine [this message]
2015-07-06 19:59 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706193941.GA1730@flurp.local \
--to=sunshine@sunshineco.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=npaolucci@atlassian.com \
--cc=tfnico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).