git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joey Hess <id@joeyh.name>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, Paul Tan <pyokagan@gmail.com>
Subject: Re: git pull --upload-pack reversion in git 2.5.0
Date: Thu, 30 Jul 2015 14:31:44 -0400	[thread overview]
Message-ID: <20150730183144.GA6360@kitenet.net> (raw)
In-Reply-To: <vpqvbd1k1ke.fsf@anie.imag.fr>

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

I think this comes down to a lack of quoting where git-pull runs
git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6,
"$@" was passed through to git-fetch, but now there is a $upload_pack
which is passed without being quoted.

-- 
see shy jo

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

  reply	other threads:[~2015-07-30 18:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 15:45 git pull --upload-pack reversion in git 2.5.0 Joey Hess
2015-07-30 17:17 ` Matthieu Moy
2015-07-30 18:31   ` Joey Hess [this message]
2015-07-30 18:41     ` Junio C Hamano
2015-07-30 20:40       ` [PATCH] pull.sh: quote $upload_pack when passing it to git-fetch Matthieu Moy
2015-07-30 21:13         ` Junio C Hamano
2015-07-31 11:01         ` Paul Tan
2015-07-31 17:54       ` git pull --upload-pack reversion in git 2.5.0 Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730183144.GA6360@kitenet.net \
    --to=id@joeyh.name \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=pyokagan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).