From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] refs: support negative transfer.hideRefs
Date: Thu, 30 Jul 2015 19:28:35 -0400 [thread overview]
Message-ID: <20150730232835.GA5805@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cTJuCWwhzrAt47yCEMv4yrTX-C1e9L_yBwyqJ-YbGfcuA@mail.gmail.com>
On Thu, Jul 30, 2015 at 04:17:35PM -0400, Eric Sunshine wrote:
> > + test_expect_success "Override hiding of $configsection.hiderefs" '
> > + test_when_finished "test_unconfig $configsection.hiderefs" &&
> > + git config --add $configsection.hiderefs refs/tags &&
> > + git config --add $configsection.hiderefs "!refs/tags/magic" &&
> > + git config --add $configsection.hiderefs refs/tags/magic/one &&
> > + git ls-remote . >actual &&
> > + verbose grep refs/tags/magic/two actual
>
> For completeness, do you also want to add
>
> !grep refs/tags/magic/one actual
>
> to confirm that the third hideRefs did indeed override the second one?
Yeah, I think that is a good change. We could also test_cmp the whole
output, but I didn't want to be dependent on other junk from previous
tests.
-Peff
prev parent reply other threads:[~2015-07-30 23:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 19:57 [PATCH 0/2] negative hideRefs for overriding Jeff King
2015-07-28 19:59 ` [PATCH 1/2] docs/config.txt: reorder hideRefs config Jeff King
2015-07-28 19:59 ` [PATCH 2/2] refs: support negative transfer.hideRefs Jeff King
2015-07-28 20:14 ` Junio C Hamano
2015-07-28 20:23 ` Jeff King
2015-07-30 20:17 ` Eric Sunshine
2015-07-30 23:28 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730232835.GA5805@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).