From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] usage: try harder to format very long error messages
Date: Tue, 11 Aug 2015 14:05:25 -0400 [thread overview]
Message-ID: <20150811180524.GB15521@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqtws5ss14.fsf@gitster.dls.corp.google.com>
On Tue, Aug 11, 2015 at 09:34:31AM -0700, Junio C Hamano wrote:
> > As for vwritef, it exists solely to work over write(), _and_ it doesn't
> > get the "one-shot" thing right (which is probably OK, as we use it only
> > when exec fails). But we could probably teach run-command to fdopen(),
> > and get rid of it entirely (in favor of teaching vreportf to take a
> > FILE* handle instead of assuming stderr).
>
> Sounds like a plan ;-)
So here's an alternative series that does this, along with the
single-fprintf thing I mentioned. The first patch is actually orthogonal
to the second; we would probably want it whichever path we choose to fix
vreportf's truncation (I'd just have to rebase the earlier patch on top
of it if we go that route).
[1/2]: vreportf: report to arbitrary filehandles
[2/2]: vreportf: avoid intermediate buffer
-Peff
next prev parent reply other threads:[~2015-08-11 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 16:17 [PATCH] usage: try harder to format very long error messages Jeff King
2015-08-11 16:28 ` Stefan Beller
2015-08-11 16:33 ` Jeff King
2015-08-11 16:34 ` Junio C Hamano
2015-08-11 18:05 ` Jeff King [this message]
2015-08-11 18:06 ` [PATCH 1/2] vreportf: report to arbitrary filehandles Jeff King
2015-08-11 18:13 ` [PATCH 2/2] vreportf: avoid intermediate buffer Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811180524.GB15521@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).