From: Jeff King <peff@peff.net>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes
Date: Mon, 24 Aug 2015 10:43:29 -0400 [thread overview]
Message-ID: <20150824144328.GA2151@sigill.intra.peff.net> (raw)
In-Reply-To: <98f2f674e384ac3af38e305165135a60@www.dscho.org>
On Mon, Aug 24, 2015 at 12:23:52PM +0200, Johannes Schindelin wrote:
> You're right. I think the best approach for now is to error out when
> `--show-notes` is passed to rev-list. Do you agree?
Yes (I imagine you didn't yet read my follow-up patch when you wrote
this). :)
-Peff
next prev parent reply other threads:[~2015-08-24 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 15:14 [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes Johannes Schindelin
2015-08-22 16:30 ` Johan Herland
2015-08-23 17:43 ` Jeff King
2015-08-23 17:56 ` [PATCH] rev-list: make it obvious that we do not support notes Jeff King
2015-08-24 10:23 ` [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes Johannes Schindelin
2015-08-24 14:43 ` Jeff King [this message]
2015-08-24 14:48 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824144328.GA2151@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).