git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "erik elfström" <erik.elfstrom@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t7300: fix broken && chains
Date: Tue, 1 Sep 2015 13:36:51 -0400	[thread overview]
Message-ID: <20150901173650.GA5723@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMpP7NZ=K62XVkuuJHpDruBy7b2gECHrJ30L43LzdE54vTVB2A@mail.gmail.com>

On Tue, Sep 01, 2015 at 08:27:59AM +0200, erik elfström wrote:

>      (
>         echo "100644 $o5 0    a"
>         echo "100644 $o0 0    c"
>         echo "160000 $c1 0    d"
>     ) >expected &&
> 
> I'd estimate that there are hundreds of these (see t3030 for
> examples). I'm not sure if you care about these? As you say they are
> not really very interesting cases.

I think patches for these are OK, but no, I don't consider it a high
priority if they are harmless (IMHO the real value of the patches is
that it removes the noise from the output of your script, so you can
find any cases that _do_ matter).

-Peff

      reply	other threads:[~2015-09-01 17:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-30  9:18 [PATCH] t7300: fix broken && chains Erik Elfström
2015-08-31 16:58 ` Junio C Hamano
2015-09-01  6:31   ` erik elfström
2015-09-01 16:23     ` Junio C Hamano
2015-08-31 18:54 ` Jeff King
2015-09-01  6:27   ` erik elfström
2015-09-01 17:36     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150901173650.GA5723@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=erik.elfstrom@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).