From: Jeff King <peff@peff.net>
To: Renato Botelho <garga@FreeBSD.org>
Cc: git@vger.kernel.org
Subject: Re: Conditionally define vars to improve portability
Date: Tue, 8 Sep 2015 02:30:34 -0400 [thread overview]
Message-ID: <20150908063034.GF26331@sigill.intra.peff.net> (raw)
In-Reply-To: <81961DE1-FA30-4E55-8818-9FCA3BC59B81@FreeBSD.org>
On Mon, Sep 07, 2015 at 02:51:42PM -0300, Renato Botelho wrote:
> Default variables used to build are set using = on Makefile, (e.g. CC,
> INSTALL, CFLAGS, …). GNU make overwrite these values if it’s passed as
> an argument (make CC=clang) and it works as expected.
>
> Default method of passing arguments for make operations on FreeBSD
> ports tree is using environment variables instead of make arguments,
> then we have CC set on env before call gmake. Today these values are
> ignored by git Makefile, and we ended up patching Makefile replacing =
> by ?= on variable assignments [1].
Hmm. I can't really think of a downside to doing so, unless we expect
users to have things like CC set in the environment and _not_ want them
to bleed through to our build.
But doesn't "gmake -e" solve your problem without a patch?
-Peff
next prev parent reply other threads:[~2015-09-08 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 17:51 Conditionally define vars to improve portability Renato Botelho
2015-09-08 6:30 ` Jeff King [this message]
2015-09-08 8:19 ` Renato Botelho
2015-09-08 18:57 ` Junio C Hamano
2015-09-08 20:09 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908063034.GF26331@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=garga@FreeBSD.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox