From: Remi Pommarel <repk@triplefau.lt>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Brandon Casey <drafnel@gmail.com>,
Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] Makefile: Change library order for static linking
Date: Tue, 22 Sep 2015 22:37:59 +0200 [thread overview]
Message-ID: <20150922203759.GB9793@cruxbox> (raw)
In-Reply-To: <xmqqh9mnbswv.fsf@gitster.mtv.corp.google.com>
On Mon, Sep 21, 2015 at 10:09:52AM -0700, Junio C Hamano wrote:
> I think I said this already, but I found these bits from your patch
>
> - $(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)
> + $(CURL_LIBCURL) $(EXPAT_LIBEXPAT) $(LIBS)
>
> that first uses libcurl and then libs (which has ssl bits) totally
> sensible. Shouldn't that be sufficient?
That is not sufficient on its own because -lssl is not added in $(LIBS), it
is only added in $(CURL_LIBCURL) if NEEDS_SSL_WITH_CURL is set.
>
> > The proper variable I should have used is
> > NEEDS_SSL_WITH_CURL. But this variable is not setted on Linux and not
> > configurable,...
>
> Really? Anything is configurable from your config.mak, I would have
> thought.
You right using the parts you find sensible and adding
"NEEDS_SSL_WITH_CURL=YesPlease" in config.mak makes git compile fine. So
I will resubmit with only the sensible part of the patch.
I have one last question thought. Wouldn't it be nice if we had
configure to autodetect the need for -lssl with libcurl ? We could make
configure to check for Curl_ssl_init function symbol in libcurl,
which is only present if libcurl has been compiled with openssl support,
by adding something like that in configure.ac:
AC_CHECK_LIB([curl], [Curl_ssl_init],
[NEEDS_SSL_WITH_CURL=YesPlease],
[NEEDS_SSL_WITH_CURL=])
The thing that I'm afraid of is that checking a function that is not part
of official libcurl API could be not very reliable, don't you think ?
next prev parent reply other threads:[~2015-09-22 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 21:12 [PATCH] Makefile: Change library order for static linking Remi Pommarel
2015-09-17 19:25 ` Eric Sunshine
2015-09-17 21:31 ` Remi Pommarel
2015-09-17 19:51 ` Junio C Hamano
2015-09-17 21:20 ` Remi Pommarel
2015-09-17 22:08 ` Junio C Hamano
2015-09-18 7:17 ` Remi Pommarel
2015-09-21 17:09 ` Junio C Hamano
2015-09-22 20:37 ` Remi Pommarel [this message]
2015-09-22 21:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922203759.GB9793@cruxbox \
--to=repk@triplefau.lt \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox