git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fredrik Gustafsson <iveqy@iveqy.com>
To: Felipe Micaroni Lalli <micaroni@walltime.info>
Cc: git@vger.kernel.org
Subject: Re: Git feature request: mark a commit as minor
Date: Sat, 3 Oct 2015 20:12:22 +0200	[thread overview]
Message-ID: <20151003181222.GA2024@paksenarrion.iveqy.com> (raw)
In-Reply-To: <560EF966.3000501@walltime.info>

On Fri, Oct 02, 2015 at 06:38:46PM -0300, Felipe Micaroni Lalli wrote:
> A minor change (also called "cosmetic") usually is a typo fix, doc
> improvement, a little code refactoring that don't change the behavior etc.
> 
> In Wikipedia we can mark an edition as "minor".
> 
> It would be nice to have an argument like "--minor" in git-commit to
> mark the commit as minor. Also, filter in git-log (like --hide-minor) to
> hide the minor changes. The git-log could be optimized to show minor
> commits more discreetly.

I can see your problem and implement your suggest is a solution that
would work. However since this is a common problem, git already has a
solution, that is the interactive rebase.

You can read a discussion about when to use merge and rebase here:
http://www.mail-archive.com/dri-devel@lists.sourceforge.net/msg39091.html

This work method make the "minor" commits to go away. There shouldn't be
any minor, or "fixup" commits in your history (of course there's
exception).

Minor things should be caught in your code review process and then
fixed, rebased and the merged again.

Or do I miss a usecase here?

-- 
Fredrik Gustafsson

phone: +46 733-608274
e-mail: iveqy@iveqy.com
website: http://www.iveqy.com

  parent reply	other threads:[~2015-10-03 18:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 21:38 Git feature request: mark a commit as minor Felipe Micaroni Lalli
2015-10-03  6:11 ` Jacob Keller
2015-10-03  6:17   ` Mikael Magnusson
2015-10-03  6:44     ` Felipe Micaroni Lalli
2015-10-04  6:01       ` Jacob Keller
2015-10-03 18:12 ` Fredrik Gustafsson [this message]
2015-10-03 19:52   ` Felipe Micaroni Lalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151003181222.GA2024@paksenarrion.iveqy.com \
    --to=iveqy@iveqy.com \
    --cc=git@vger.kernel.org \
    --cc=micaroni@walltime.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).