From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] git-gui: sort entries in tclIndex Date: Mon, 5 Oct 2015 09:43:32 +0200 Message-ID: <20151005074332.GA21840@aepfle.de> References: <1422292043-12711-1-git-send-email-olaf@aepfle.de> <20150210151803.GB8965@aepfle.de> <20150415072251.GA18595@aepfle.de> <553BC05F.1070702@web.de> <87sibgpcpp.fsf@red.patthoyts.tk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?utf-8?B?UmVuw6k=?= Scharfe , git@vger.kernel.org To: Pat Thoyts X-From: git-owner@vger.kernel.org Mon Oct 05 09:50:30 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zj0XT-0007vR-4b for gcvg-git-2@plane.gmane.org; Mon, 05 Oct 2015 09:50:27 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbbJEHuN convert rfc822-to-quoted-printable (ORCPT ); Mon, 5 Oct 2015 03:50:13 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.162]:37643 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbbJEHtt (ORCPT ); Mon, 5 Oct 2015 03:49:49 -0400 X-Greylist: delayed 374 seconds by postgrey-1.27 at vger.kernel.org; Mon, 05 Oct 2015 03:49:49 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1444031388; l=1396; s=domk; d=aepfle.de; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Subject:Cc:To:From:Date; bh=78VC8Dcnmx5bdI0MjTtmsNYHjj2BKwUp0qgDsbT2j9c=; b=EFrOs2O4Ev8khuj7Nkx4tDaVSZpd05xx2eKjW8/gd9vGAykFROC/KZBWd5PXUcC0amX 2FKx11XKnUcdbhiTAVrxk9hCowfJMnCmYWjiOugQbkTikYLEvKV94AlUsWOduTqbdCL2i PBZek3oHS0UMH192wjBKsGCQyhEWuL8/nSo= X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWtqWFmrC5F/k8792rLukQ== X-RZG-CLASS-ID: mo00 Received: from probook.fritz.box (aftr-185-17-204-205.dynamic.mnet-online.de [185.17.204.205]) by smtp.strato.de (RZmta 37.12 DYNA|AUTH) with ESMTPSA id 60269ar957hXSeo (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 5 Oct 2015 09:43:33 +0200 (CEST) Received: by probook.fritz.box (Postfix, from userid 1000) id 1B4D8508B6; Mon, 5 Oct 2015 09:43:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <87sibgpcpp.fsf@red.patthoyts.tk> User-Agent: Mutt/1.5.24 (6517) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: To which branch was this applied? Its still broken in git-2.6.0. Olaf On Fri, May 01, Pat Thoyts wrote: > Ren=C3=A9 Scharfe writes: >=20 > >Looping in Pat (git-gui maintainer). > > > >Am 15.04.2015 um 09:22 schrieb Olaf Hering: > >> Ping? > >> > >> On Tue, Feb 10, Olaf Hering wrote: > >> > >>> Ping? > >>> > >>> On Mon, Jan 26, Olaf Hering wrote: > >>> > >>>> ALL_LIBFILES uses wildcard, which provides the result in directo= ry > >>>> order. This order depends on the underlying filesystem on the > >>>> buildhost. To get reproducible builds it is required to sort suc= h list > >>>> before using them. > >>>> > >>>> Signed-off-by: Olaf Hering > >>>> --- > >>>> git-gui/Makefile | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/git-gui/Makefile b/git-gui/Makefile > >>>> index cde8b2e..7564a18 100644 > >>>> --- a/git-gui/Makefile > >>>> +++ b/git-gui/Makefile > >>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS > >>>> rm -f $@ ; \ > >>>> echo '# Autogenerated by git-gui Makefile' >$@ && \ > >>>> echo >>$@ && \ > >>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst li= b/,,$p)' >>$@ &&) \ > >>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(= subst lib/,,$p)' >>$@ &&) \ > >>>> echo >>$@ ; \ > >>>> fi > >>>> > > >=20 > Applied. Thank you.