From: Jonathan Nieder <jrnieder@gmail.com>
To: Remi Pommarel <repk@triplefau.lt>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Brandon Casey <drafnel@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 1/1] Makefile: make curl-config path configurable
Date: Mon, 5 Oct 2015 12:31:27 -0700 [thread overview]
Message-ID: <20151005193127.GC11993@google.com> (raw)
In-Reply-To: <1444072858-24399-1-git-send-email-repk@triplefau.lt>
Remi Pommarel wrote:
> There are situations, ie during cross compilation, where curl-config program
> is not present in the PATH.
s/ie/e.g.,/
[...]
> @@ -374,6 +378,7 @@ LDFLAGS =
> ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS)
> ALL_LDFLAGS = $(LDFLAGS)
> STRIP ?= strip
> +CURL_CONFIG = curl-config
Could this go down with the other programs (CC, AR, FIND, et al)?
The rest looks good.
Jonathan
next prev parent reply other threads:[~2015-10-05 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 19:20 [PATCH v2 1/1] Makefile: make curl-config path configurable Remi Pommarel
2015-10-05 19:31 ` Jonathan Nieder [this message]
2015-10-05 20:25 ` Remi Pommarel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005193127.GC11993@google.com \
--to=jrnieder@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=repk@triplefau.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).