From: Remi Pommarel <repk@triplefau.lt>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Brandon Casey <drafnel@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 1/1] Makefile: make curl-config path configurable
Date: Mon, 5 Oct 2015 22:25:08 +0200 [thread overview]
Message-ID: <20151005202508.GB386@cruxbox> (raw)
In-Reply-To: <20151005193127.GC11993@google.com>
On Mon, Oct 05, 2015 at 12:31:27PM -0700, Jonathan Nieder wrote:
> Remi Pommarel wrote:
>
> > There are situations, ie during cross compilation, where curl-config program
> > is not present in the PATH.
>
> s/ie/e.g.,/
Oups sorry about that.
>
> [...]
> > @@ -374,6 +378,7 @@ LDFLAGS =
> > ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS)
> > ALL_LDFLAGS = $(LDFLAGS)
> > STRIP ?= strip
> > +CURL_CONFIG = curl-config
>
> Could this go down with the other programs (CC, AR, FIND, et al)?
Yes sure that makes sense. I'll resend a modified patch, thanks
--
Rémi
prev parent reply other threads:[~2015-10-05 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 19:20 [PATCH v2 1/1] Makefile: make curl-config path configurable Remi Pommarel
2015-10-05 19:31 ` Jonathan Nieder
2015-10-05 20:25 ` Remi Pommarel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005202508.GB386@cruxbox \
--to=repk@triplefau.lt \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox