From: Tobias Klauser <tklauser@distanz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>, git@vger.kernel.org
Subject: Re: [PATCH 1/5] gc: remove unused #include "sigchain.h"
Date: Fri, 23 Oct 2015 09:25:28 +0200 [thread overview]
Message-ID: <20151023072527.GR2468@distanz.ch> (raw)
In-Reply-To: <xmqqk2qer78a.fsf@gitster.mtv.corp.google.com>
On 2015-10-22 at 22:14:29 +0200, Junio C Hamano <gitster@pobox.com> wrote:
> Tobias Klauser <tklauser@distanz.ch> writes:
>
> > After switching to use the tempfile module in commit ebebeaea (gc: use
> > tempfile module to handle gc.pid file), no declarations from sigchain.h
> > are used in builtin/gc.c anymore. Thus, remove the #include.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > ---
>
> I'll drop this one as we seem to have gained another user of the API
> in this file in the nd/gc-auto-background-fix topic.
Opps, sorry I didn't check against 'pu' carefully enough. Thanks for
catching it.
next prev parent reply other threads:[~2015-10-23 7:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 12:43 [PATCH 0/5] Remove unused #include "sigchain.h" Tobias Klauser
2015-10-22 12:43 ` [PATCH 1/5] gc: remove " Tobias Klauser
2015-10-22 20:14 ` Junio C Hamano
2015-10-23 7:25 ` Tobias Klauser [this message]
2015-10-23 17:00 ` Junio C Hamano
2015-10-22 12:43 ` [PATCH 2/5] credential-cache--daemon: " Tobias Klauser
2015-10-22 12:43 ` [PATCH 3/5] diff: " Tobias Klauser
2015-10-22 12:43 ` [PATCH 4/5] read-cache: " Tobias Klauser
2015-10-22 12:43 ` [PATCH 5/5] shallow: " Tobias Klauser
2015-10-22 17:30 ` [PATCH 0/5] Remove " Junio C Hamano
2015-10-26 20:59 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023072527.GR2468@distanz.ch \
--to=tklauser@distanz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).