From: Jeff King <peff@peff.net>
To: Andrei Borzenkov <arvidjaar@gmail.com>
Cc: The development of GRUB 2 <grub-devel@gnu.org>,
git@vger.kernel.org, savannah-users@gnu.org
Subject: Re: Anonymous commit (empty Author and Committer)
Date: Fri, 30 Oct 2015 13:01:03 -0400 [thread overview]
Message-ID: <20151030170102.GA32384@sigill.intra.peff.net> (raw)
In-Reply-To: <56337DF8.5050802@gmail.com>
On Fri, Oct 30, 2015 at 05:26:00PM +0300, Andrei Borzenkov wrote:
> See http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>
> I was not even aware that this is possible. Is there anything on server side
> that can prevent it?
I would have thought that receive.fsckObjects would reject it, but seems
that git-fsck does not complain about it at all, as it is otherwise
syntactically valid (a space separating the zero-length name from the
email, and <> surrounding the empty email).
We do complain during "git commit" about an empty name. We don't seem to
do so for blank emails, though. The only discussion I could find
mentions that should probably disallow both[1].
I wonder how this commit was created in the first place (through
git-commit, and we have an empty-name case that is not covered, or using
a lower-level tool that bypasses the checks).
-Peff
[1] http://article.gmane.org/gmane.comp.version-control.git/261237
next prev parent reply other threads:[~2015-10-30 17:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 14:26 Anonymous commit (empty Author and Committer) Andrei Borzenkov
2015-10-30 14:33 ` Konstantin Khomoutov
[not found] ` <56338C30.6010302@riseup.net>
2015-10-30 15:39 ` [Savannah-users] " Balaco Baco
2015-10-30 17:01 ` Jeff King [this message]
[not found] ` <5633CDCD.10004@gmail.com>
2015-10-30 20:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-30 20:19 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-30 20:59 ` Lennart Sorensen
2015-10-30 21:45 ` Kaz Kylheku
2015-10-31 7:02 ` Andreas Schwab
2015-10-31 13:46 ` Andrei Borzenkov
2015-10-31 5:24 ` Andrei Borzenkov
2015-11-02 15:11 ` Lennart Sorensen
2015-11-02 16:37 ` [Savannah-users] " Kaz Kylheku
2015-11-02 16:42 ` Junio C Hamano
2015-10-31 13:54 ` Andrei Borzenkov
-- strict thread matches above, loose matches on Subject: below --
2015-10-31 12:12 André Z. D. A.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030170102.GA32384@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=arvidjaar@gmail.com \
--cc=git@vger.kernel.org \
--cc=grub-devel@gnu.org \
--cc=savannah-users@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).