From: Jeff King <peff@peff.net>
To: Daniel Stenberg <daniel@haxx.se>
Cc: David Turner <dturner@twopensource.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] http.c: use CURLOPT_RANGE for range requests
Date: Sun, 1 Nov 2015 20:51:58 -0500 [thread overview]
Message-ID: <20151102015157.GA25597@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1511012359150.24283@tvnag.unkk.fr>
On Mon, Nov 02, 2015 at 12:00:42AM +0100, Daniel Stenberg wrote:
> On Fri, 30 Oct 2015, Jeff King wrote:
>
> >The goal makes sense. Why weren't we using CURLOPT_RANGE before? Did it
> >not exist (or otherwise have limitations) in 2005, and if so, when did it
> >become usable? Do we need to protect this with an #ifdef for the curl
> >version?
>
> CURLOPT_RANGE existed already in the first libcurl release: version 7.1,
> relased in August 2000.
Ah, thanks. I guess we don't have to worry about that, then.
While I have your attention, Daniel, am I correct in assuming that
performing a second unrelated request with the same CURL object will
need an explicit:
curl_easy_setopt(curl, CURLOPT_RANGE, NULL);
to avoid using the range twice?
-Peff
next prev parent reply other threads:[~2015-11-02 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 22:54 [PATCH v2] http.c: use CURLOPT_RANGE for range requests David Turner
2015-10-30 23:13 ` Junio C Hamano
2015-10-31 0:08 ` Jeff King
2015-10-31 17:40 ` Junio C Hamano
2015-10-31 17:43 ` Jeff King
2015-11-01 23:00 ` Daniel Stenberg
2015-11-02 1:51 ` Jeff King [this message]
2015-11-02 7:05 ` Daniel Stenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102015157.GA25597@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=daniel@haxx.se \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).