From: Jeff King <peff@peff.net>
To: David Turner <dturner@twopensource.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, git@vger.kernel.org
Subject: Re: [PATCH v3] http.c: use CURLOPT_RANGE for range requests
Date: Mon, 2 Nov 2015 17:45:57 -0500 [thread overview]
Message-ID: <20151102224556.GA16387@sigill.intra.peff.net> (raw)
In-Reply-To: <1446504084.4131.33.camel@twopensource.com>
On Mon, Nov 02, 2015 at 05:41:24PM -0500, David Turner wrote:
> > Let's switch to using off_t, which should hold any file size
> > our system is capable of storing. We need to use ftello() to
> > get the off_t. This is in POSIX and hopefully available
> > everywhere; if not, we should be able to wrap it by falling
> > back to ftell(), which would presumably return "-1" on such
> > a large file (and we would simply skip resuming in that case).
>
> It would skip resuming, but would still maybe write to the end of the
> existing file, right? So I think we would need to seek to the beginning
> of the file in that case.
Oh, you're right. That's no worse than the current behavior, but it's
definitely not ideal. I'd leave that for a follow-on patch that actually
implements such an ftello wrapper.
-Peff
prev parent reply other threads:[~2015-11-02 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 19:36 [PATCH v3] http.c: use CURLOPT_RANGE for range requests David Turner
2015-11-02 20:18 ` Jeff King
2015-11-02 21:50 ` Andreas Schwab
2015-11-02 22:10 ` Jeff King
2015-11-02 22:41 ` David Turner
2015-11-02 22:45 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151102224556.GA16387@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).