From: Jeff King <peff@peff.net>
To: Jonathan Lebon <jonathan.lebon@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] diff-highlight: add `less -r` to cmd in README
Date: Tue, 3 Nov 2015 16:14:36 -0500 [thread overview]
Message-ID: <20151103211435.GA22484@sigill.intra.peff.net> (raw)
In-Reply-To: <1446516334-27652-2-git-send-email-jonathan.lebon@gmail.com>
On Mon, Nov 02, 2015 at 09:05:31PM -0500, Jonathan Lebon wrote:
> As it is, the suggested command for trying out diff-highlight will just
> dump the whole git log output to the terminal. Let's pipe it through
> `less` so users aren't surprised on the first try.
That makes sense. I use "diff-highlight | less" myself, of course. I
think I excluded it from the README in the name of simplicity, but you
are right that it is probably better to give a complete working example.
I agree with Junio that "-R" is a more sensible default, but I don't
think that should be necessary. We already set LESS when running the
pager (and if you are overriding it, you are already in trouble, because
git itself will generate ANSI codes by default).
-Peff
next prev parent reply other threads:[~2015-11-03 21:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 2:05 [PATCH 0/4] diff-highlight: make a few improvements Jonathan Lebon
2015-11-03 2:05 ` [PATCH 1/4] diff-highlight: add `less -r` to cmd in README Jonathan Lebon
2015-11-03 2:41 ` Junio C Hamano
2015-11-03 3:12 ` Jonathan Lebon
2015-11-03 21:14 ` Jeff King [this message]
2015-11-03 21:51 ` Junio C Hamano
2015-11-03 21:55 ` Jeff King
2015-11-03 2:05 ` [PATCH 2/4] diff-highlight: factor out prefix/suffix functions Jonathan Lebon
2015-11-03 21:17 ` Jeff King
2015-11-03 2:05 ` [PATCH 3/4] diff-highlight: match up lines before highlighting Jonathan Lebon
2015-11-03 21:44 ` Jeff King
2015-11-03 22:03 ` Jeff King
2015-11-17 5:18 ` Jonathan Lebon
2015-11-17 22:50 ` Jeff King
2015-11-03 2:05 ` [PATCH 4/4] diff-highlight: add maxhunksize config option Jonathan Lebon
2015-11-03 21:46 ` Jeff King
2015-11-03 22:07 ` [PATCH 0/4] diff-highlight: make a few improvements Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103211435.GA22484@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jonathan.lebon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).