From: Jeff King <peff@peff.net>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Cc: git@vger.kernel.org, gitster@pobox.com, adam@dinwoodie.org,
ramsay@ramsayjones.plus.com
Subject: Re: [PATCH] t5813: avoid creating urls that break on cygwin
Date: Mon, 9 Nov 2015 10:45:01 -0500 [thread overview]
Message-ID: <20151109154501.GA27224@sigill.intra.peff.net> (raw)
In-Reply-To: <20151108095400.GA9448@spirit>
On Sun, Nov 08, 2015 at 10:54:04AM +0100, Dennis Kaarsemaker wrote:
> The fake ssh used by this test simply strips ssh://host from the url,
> leaving paths behind that start with //, which cygwin interprets as UNC
> paths, causing the test to fail.
I found the first sentence a little misleading. It is git itself that
strips the URL, isn't it? The problem is that we are feeding a URL with
a bogus path, which the fake ssh then tries to access (but in a way that
happens to work on Unix systems).
-Peff
next prev parent reply other threads:[~2015-11-09 15:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 12:11 Bug: t5813 failing on Cygwin Adam Dinwoodie
2015-11-07 18:45 ` Jeff King
2015-11-07 19:20 ` Adam Dinwoodie
2015-11-07 21:02 ` Dennis Kaarsemaker
2015-11-07 21:21 ` Ramsay Jones
2015-11-07 23:05 ` Ramsay Jones
2015-11-07 23:32 ` Dennis Kaarsemaker
2015-11-08 1:46 ` Ramsay Jones
2015-11-08 7:11 ` Torsten Bögershausen
2015-11-07 23:24 ` Adam Dinwoodie
2015-11-08 5:10 ` Jeff King
2015-11-08 9:54 ` [PATCH] t5813: avoid creating urls that break on cygwin Dennis Kaarsemaker
2015-11-09 15:45 ` Jeff King [this message]
2015-11-09 17:49 ` Dennis Kaarsemaker
2015-11-09 17:50 ` Jeff King
2015-11-08 13:21 ` Bug: t5813 failing on Cygwin Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109154501.GA27224@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=adam@dinwoodie.org \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).