From: Jeff King <peff@peff.net>
To: Victor Leschuk <vleschuk@accesssoftek.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Victor Leschuk <vleschuk@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"john@keeping.me.uk" <john@keeping.me.uk>
Subject: Re: [PATCH v4] Add git-grep threads param
Date: Mon, 9 Nov 2015 10:55:38 -0500 [thread overview]
Message-ID: <20151109155538.GC27224@sigill.intra.peff.net> (raw)
In-Reply-To: <6AE1604EE3EC5F4296C096518C6B77EE5D0FDABA15@mail.accesssoftek.com>
On Mon, Nov 09, 2015 at 03:36:16AM -0800, Victor Leschuk wrote:
> Yeah do also think it would be more reasonable to use "0" for
> "autodetect" default value. However chat this autodetect value should
> be?
>
> For index index-pack and pack-objects we use ncpus() for this, however
> according to my tests this wouldn't an Ideal for all cases. Maybe it
> should be something like ncpus()*2,
> anyway before it we even used hard-coded 8 for all systems...
Why don't we leave it at 8, then? That's the conservative choice, and
once we have --threads, people can easily experiment with different
values and we can follow-up with a change to the default if need be.
-Peff
next prev parent reply other threads:[~2015-11-09 15:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 21:22 [PATCH v4] Add git-grep threads param Victor Leschuk
2015-11-02 4:43 ` Victor Leschuk
2015-11-02 15:13 ` Junio C Hamano
2015-11-03 8:36 ` Victor Leschuk
2015-11-03 17:22 ` Junio C Hamano
2015-11-04 6:40 ` Jeff King
2015-11-09 11:36 ` Victor Leschuk
2015-11-09 15:55 ` Jeff King [this message]
2015-11-09 16:34 ` Victor Leschuk
2015-11-09 16:53 ` Jeff King
2015-11-09 17:28 ` Victor Leschuk
2015-11-09 17:47 ` Jeff King
2015-11-09 17:55 ` Linus Torvalds
2015-11-09 18:13 ` Jeff King
2015-11-09 18:32 ` Victor Leschuk
2015-11-09 19:11 ` Linus Torvalds
2015-11-09 19:52 ` Victor Leschuk
[not found] ` <CA+55aFyhBN5fEpB-CLQFhhDyf7nijs_Y3aZCSQAcpVPmruZLFg@mail.gmail.com>
2015-11-09 21:51 ` Victor Leschuk
2015-11-09 18:40 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109155538.GC27224@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=torvalds@linux-foundation.org \
--cc=vleschuk@accesssoftek.com \
--cc=vleschuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).