From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] http: fix some printf format warnings on 32-bit builds
Date: Wed, 11 Nov 2015 15:54:06 -0500 [thread overview]
Message-ID: <20151111205405.GA31494@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cS54yTsZ8NWjyh6kj6nXy966EkYPHh_sjMbMcDGemnFuA@mail.gmail.com>
On Wed, Nov 11, 2015 at 03:31:01PM -0500, Eric Sunshine wrote:
> The fact that 'long' and 'long long' happen to be the same size (in
> this case) is immaterial. What is important is that the code is just
> wrong to be using the "%l" specifier for 'long' when the actual
> datatype is 'long long' (which is what 'off_t' is under-the-hood in
> this case).
Right. We cannot assume anything about what is in off_t, and should be
casting to uintmax_t. So the patch is right, but I agree the commit
message could be better. I started to hack it up myself, but I didn't
want to put too many words in Ramsay's mouth. Do you mind resending with
an updated commit message?
Thanks (and thank you in the first place for finding and fixing the
breakage I introduced in f8117f55).
-Peff
next prev parent reply other threads:[~2015-11-11 20:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 0:23 [PATCH] http: fix some printf format warnings on 32-bit builds Ramsay Jones
2015-11-11 1:22 ` Eric Sunshine
2015-11-11 2:00 ` Stefan Beller
2015-11-11 8:02 ` Lars Schneider
2015-11-11 17:38 ` Stefan Beller
2015-11-11 17:49 ` Ramsay Jones
2015-11-13 8:46 ` Lars Schneider
2015-11-13 8:57 ` Eric Sunshine
2015-11-13 10:32 ` Torsten Bögershausen
2015-11-13 12:08 ` Lars Schneider
2015-11-13 20:02 ` Ramsay Jones
2015-11-14 19:14 ` Lars Schneider
2015-11-11 17:47 ` Ramsay Jones
2015-11-11 20:31 ` Eric Sunshine
2015-11-11 20:54 ` Jeff King [this message]
2015-11-11 20:58 ` Ramsay Jones
2015-11-12 5:27 ` Torsten Bögershausen
2015-11-12 11:58 ` Ramsay Jones
2015-11-12 18:40 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111205405.GA31494@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).