From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] http: fix some printf format warnings
Date: Wed, 11 Nov 2015 19:11:34 -0500 [thread overview]
Message-ID: <20151112001134.GA8572@sigill.intra.peff.net> (raw)
In-Reply-To: <5643D84E.2070904@ramsayjones.plus.com>
On Thu, Nov 12, 2015 at 12:07:42AM +0000, Ramsay Jones wrote:
> Commit f8117f55 ("http: use off_t to store partial file size",
> 02-11-2015) changed the type of some variables from long to off_t.
> Unfortunately, the off_t type is not portable and can be represented
> by several different actual types (even multiple types on the same
> platform). This makes it difficult to print an off_t variable in
> a platform independent way. As a result, this commit causes gcc to
> issue some printf format warnings on a couple of different platforms.
>
> In order to suppress the warnings, change the format specifier to use
> the PRIuMAX macro and cast the off_t argument to uintmax_t. (See also
> the http_opt_request_remainder() function, which uses the same
> solution).
Thanks, that's even better than what I had ghost-written for you. :)
-Peff
prev parent reply other threads:[~2015-11-12 0:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 0:07 [PATCH] http: fix some printf format warnings Ramsay Jones
2015-11-12 0:11 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112001134.GA8572@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).