From: Jeff King <peff@peff.net>
To: Clemens Buchacher <clemens.buchacher@intel.com>
Cc: git@vger.kernel.org, junio@pobox.com
Subject: Re: [PATCH] allow hooks to ignore their standard input stream
Date: Fri, 13 Nov 2015 01:18:48 -0500 [thread overview]
Message-ID: <20151113061847.GD32157@sigill.intra.peff.net> (raw)
In-Reply-To: <20151111143920.GA30409@musxeris015.imu.intel.com>
On Wed, Nov 11, 2015 at 03:39:20PM +0100, Clemens Buchacher wrote:
> Since ec7dbd145 (receive-pack: allow hooks to ignore its standard input
> stream) the pre-receive and post-receive hooks ignore SIGPIPE. Do the
> same for the remaining hooks pre-push and post-rewrite, which read from
> standard input. The same arguments for ignoring SIGPIPE apply.
The reasoning and the patch itself look good to me. I posted some
thoughts on tests in response to your other message.
-Peff
prev parent reply other threads:[~2015-11-13 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 14:39 [PATCH] allow hooks to ignore their standard input stream Clemens Buchacher
2015-11-11 14:42 ` Clemens Buchacher
2015-11-13 6:17 ` Jeff King
2015-11-13 9:33 ` Clemens Buchacher
2015-11-13 23:23 ` Jeff King
2015-11-16 8:05 ` Clemens Buchacher
2015-11-16 13:59 ` Jeff King
2015-11-13 6:18 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113061847.GD32157@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=clemens.buchacher@intel.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).