From: Jeff King <peff@peff.net>
To: Andreas Krey <a.krey@gmx.de>
Cc: "erik elfström" <erik.elfstrom@gmail.com>, git@vger.kernel.org
Subject: Re: git clean performance issues
Date: Fri, 13 Nov 2015 18:53:34 -0500 [thread overview]
Message-ID: <20151113235334.GA18260@sigill.intra.peff.net> (raw)
In-Reply-To: <20151113141907.GB16219@inner.h.apk.li>
On Fri, Nov 13, 2015 at 03:19:07PM +0100, Andreas Krey wrote:
> On Sat, 04 Apr 2015 15:55:07 +0000, Jeff King wrote:
> ...
> > I think this is the same issue that was discussed here:
> >
> > http://thread.gmane.org/gmane.comp.version-control.git/265560/focus&5585
> >
> > There is some discussion of a possible fix in that thread. I was hoping
> > that Andreas was going to look further and produce a patch, but I
> > imagine he got busy with other things.
>
> That about sums it up. However I now have a similar issue;
> git ls-files shows the same behaviour (takes relatively
> forever at 100% CPU), and runs instantly with my patch
> from back then. Nothing seems to have changed, so I
> may have another chance to look into this.
Yeah, I think Erik's patch in 0179ca7 (clean: improve performance when
removing lots of directories, 2015-06-15) handles the git-clean case the
way we want to, but all of the other calls to resolve_gitlink_ref need
to be inspected and fixed similarly.
The one your are hitting with ls-files is probably in dir.c:treat_directory.
-Peff
prev parent reply other threads:[~2015-11-13 23:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 18:32 git clean performance issues erik elfström
2015-04-04 19:55 ` Jeff King
2015-04-04 20:39 ` erik elfström
2015-04-04 20:48 ` Jeff King
2015-11-13 14:19 ` Andreas Krey
2015-11-13 23:53 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113235334.GA18260@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=a.krey@gmx.de \
--cc=erik.elfstrom@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).