* [PATCH] blame: add test case for using tag object as a final ref
@ 2015-11-18 5:36 Max Kirillov
2015-11-18 6:00 ` Jeff King
0 siblings, 1 reply; 3+ messages in thread
From: Max Kirillov @ 2015-11-18 5:36 UTC (permalink / raw)
To: Jeff King, Eric Sunshine; +Cc: Max Kirillov, Edmundo Carmona Antoranz, Git List
It was discovered [1] that 1b0d40000a broke blaming starting from tag object.
Add test which verifies such blaming works.
[1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net
Signed-off-by: Max Kirillov <max@max630.net>
---
Thank you. Sorry, I should have noticed that obj ended up unused.
Adding test case for it. Looks ok after the fix.
t/annotate-tests.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
index b1673b3..093832f 100644
--- a/t/annotate-tests.sh
+++ b/t/annotate-tests.sh
@@ -68,6 +68,13 @@ test_expect_success 'blame 1 author' '
check_count A 2
'
+test_expect_success 'blame by tag objects' '
+ git tag -m "test tag" testTag &&
+ git tag -m "test tag #2" testTag2 testTag &&
+ check_count -h testTag A 2 &&
+ check_count -h testTag2 A 2
+'
+
test_expect_success 'setup B lines' '
echo "2A quick brown fox jumps over the" >>file &&
echo "lazy dog" >>file &&
--
2.3.4.2801.g3d0809b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blame: add test case for using tag object as a final ref
2015-11-18 5:36 [PATCH] blame: add test case for using tag object as a final ref Max Kirillov
@ 2015-11-18 6:00 ` Jeff King
0 siblings, 0 replies; 3+ messages in thread
From: Jeff King @ 2015-11-18 6:00 UTC (permalink / raw)
To: Max Kirillov; +Cc: Eric Sunshine, Edmundo Carmona Antoranz, Git List
On Wed, Nov 18, 2015 at 07:36:32AM +0200, Max Kirillov wrote:
> It was discovered [1] that 1b0d40000a broke blaming starting from tag object.
> Add test which verifies such blaming works.
>
> [1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net
>
> Signed-off-by: Max Kirillov <max@max630.net>
> ---
> Thank you. Sorry, I should have noticed that obj ended up unused.
Thanks. Do you mind if I just squash this into the patch with the fix?
-Peff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blame: add test case for using tag object as a final ref
@ 2015-11-18 10:35 Max Kirillov
0 siblings, 0 replies; 3+ messages in thread
From: Max Kirillov @ 2015-11-18 10:35 UTC (permalink / raw)
To: Jeff King; +Cc: Eric Sunshine, Edmundo Carmona Antoranz, Git List
On Wed, Nov 18, 2015 at 8:00 AM, Jeff King <peff@peff.net> wrote:
> On Wed, Nov 18, 2015 at 07:36:32AM +0200, Max Kirillov wrote:
>
>> It was discovered [1] that 1b0d40000a broke blaming starting from tag object.
>> Add test which verifies such blaming works.
>>
>> [1] http://mid.gmane.org/20151117224809.GE27862@sigill.intra.peff.net
>>
>> Signed-off-by: Max Kirillov <max@max630.net>
>> ---
>> Thank you. Sorry, I should have noticed that obj ended up unused.
>
> Thanks. Do you mind if I just squash this into the patch with the fix?
Not at all, please squash. 2 patches seem too many indeed
--
Max
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-18 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-18 5:36 [PATCH] blame: add test case for using tag object as a final ref Max Kirillov
2015-11-18 6:00 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2015-11-18 10:35 Max Kirillov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).