From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Johannes Sixt <j6t@kdbg.org>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/7] Modernize t9300-fast-import
Date: Fri, 20 Nov 2015 06:22:23 -0500 [thread overview]
Message-ID: <20151120112223.GD11198@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cSH+BnvnzVY=YhRknynyWkAdbXNMvvrb7GcjEnf6UDFug@mail.gmail.com>
On Thu, Nov 19, 2015 at 10:54:11PM -0500, Eric Sunshine wrote:
> On Thu, Nov 19, 2015 at 2:09 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> > Some time ago, I had to dig into t9300-fast-import and found it quite
> > unhelpful that it does not follow our modern best-practices. This series
> > brings it up-to-date. I thought I submit it now while it is quiet in
> > the area.
> >
> > The larger patches are best viewed using -w -color-words because the
> > regular patch text is ... overwhelming.
>
> For what it's worth, I read through the series (with care, I hope) and
> didn't find anything amiss.
Thanks, both. I gave it a quick read and didn't see anything wrong. The
end result is certainly nicer to read. :)
-Peff
prev parent reply other threads:[~2015-11-20 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 19:09 [PATCH 0/7] Modernize t9300-fast-import Johannes Sixt
2015-11-19 19:09 ` [PATCH 1/7] modernize t9300: single-quote placement and indentation Johannes Sixt
2015-11-19 19:09 ` [PATCH 2/7] modernize t9300: use test_must_fail Johannes Sixt
2015-11-19 19:09 ` [PATCH 3/7] modernize t9300: use test_must_be_empty Johannes Sixt
2015-11-19 19:09 ` [PATCH 4/7] modernize t9300: wrap lines after && Johannes Sixt
2015-11-19 19:09 ` [PATCH 5/7] modernize t9300: use test_when_finished for clean-up Johannes Sixt
2015-11-19 19:09 ` [PATCH 6/7] modernize t9300: mark here-doc words to ignore tab indentation Johannes Sixt
2015-11-19 19:09 ` [PATCH 7/7] modernize t9300: move test preparations into test_expect_success Johannes Sixt
2015-11-20 3:54 ` [PATCH 0/7] Modernize t9300-fast-import Eric Sunshine
2015-11-20 11:22 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120112223.GD11198@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).