From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Lars Schneider <larsxschneider@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] test-lib-functions: fix logic error in test_must_fail
Date: Tue, 24 Nov 2015 19:10:41 -0500 [thread overview]
Message-ID: <20151125001040.GA19620@sigill.intra.peff.net> (raw)
In-Reply-To: <5654FB50.4000102@ramsayjones.plus.com>
On Wed, Nov 25, 2015 at 12:05:36AM +0000, Ramsay Jones wrote:
> > ...
> > if ! list_contains "$_test_ok" success && test "$exit_code" -eq 0
> > then
> > return 0
> > fi
> ^^
> Is this intended to be part of the if..elif.. chain, or a separate
> initial conditional? Hmm, actually it doesn't matter since it has
> exactly the same logic error as the original patch ... :-D
I meant it as part of the same one, but yeah, it has the wrong "return"
(I noticed it when writing up the real patch as a SQUASH on top of
Lars's topics).
> > They don't fail consistently. It's a SIGPIPE race.
>
> Yes, and unfortunately I can't get it to happen for me.
> Which platforms has it been observed on?
I haven't tried to reproduce it, but I think it was seen originally in
the Travis build.
-Peff
prev parent reply other threads:[~2015-11-25 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 15:59 [PATCH] test-lib-functions: fix logic error in test_must_fail Ramsay Jones
2015-11-24 21:08 ` Jeff King
2015-11-25 0:05 ` Ramsay Jones
2015-11-25 0:10 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125001040.GA19620@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).