From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make error message after failing commit_lock_file() less confusing
Date: Tue, 1 Dec 2015 18:17:01 -0500 [thread overview]
Message-ID: <20151201231701.GB13245@sigill.intra.peff.net> (raw)
In-Reply-To: <1448883653-9140-1-git-send-email-szeder@ira.uka.de>
On Mon, Nov 30, 2015 at 12:40:53PM +0100, SZEDER Gábor wrote:
> The error message after a failing commit_lock_file() call sometimes
> looks like this, causing confusion:
>
> $ git remote add remote git@server.com/repo.git
> error: could not commit config file .git/config
> # Huh?!
> # I didn't want to commit anything, especially not my config file!
I like the intent of this patch; I've had the same "huh" moment myself.
> The error message is of course bikeshedable.
You chose "write", which I think is OK. It's really a "rename", and
maybe that matters for some values of errno. I'd guess in practice
probably not (the likely reason is going to be something like EPERM).
And I can't think of a concise way to express rename (just saying
"rename" is confusing, too, without indicating that it's from the
tempfile to the final resting place).
So perhaps "write" is the best we can do.
-Peff
next prev parent reply other threads:[~2015-12-01 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 11:40 [PATCH] Make error message after failing commit_lock_file() less confusing SZEDER Gábor
2015-12-01 23:17 ` Jeff King [this message]
2015-12-02 2:19 ` Junio C Hamano
2015-12-02 4:28 ` Eric Sunshine
2015-12-03 10:30 ` SZEDER Gábor
2015-12-03 10:31 ` [PATCH v2] " SZEDER Gábor
2015-12-16 11:22 ` [PATCH] credential-store: don't pass strerror to die_errno() SZEDER Gábor
2015-12-16 18:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201231701.GB13245@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).