From: Jeff King <peff@peff.net>
To: Mike Crowe <mac@mcrowe.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] push: add recurseSubmodules config option
Date: Tue, 1 Dec 2015 19:40:32 -0500 [thread overview]
Message-ID: <20151202004031.GA28197@sigill.intra.peff.net> (raw)
In-Reply-To: <1448970583-14513-1-git-send-email-mac@mcrowe.com>
On Tue, Dec 01, 2015 at 11:49:43AM +0000, Mike Crowe wrote:
> The --recurse-submodules command line parameter has existed for some
> time but it has no config file equivalent.
>
> Following the style of the corresponding parameter for git fetch,
> invent push.recurseSubmodules to provide a default for this parameter.
> This also requires the addition of --recurse-submodules=no to allow
> the configuration to be overridden on the command line when required.
>
> The most straightforward way to implement this appears to be to make
> push use code in submodule-config in a similar way to fetch.
>
> Signed-off-by: Mike Crowe <mac@mcrowe.com>
> ---
> Changes in v3:
Hrm, I merged v2 of this to 'next' last week.
The options at this point are either to revert that and re-start the
topic, or just make the further changes a patch on top. Thoughts?
-Peff
next prev parent reply other threads:[~2015-12-02 0:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 11:49 [PATCH v3] push: add recurseSubmodules config option Mike Crowe
2015-12-02 0:40 ` Jeff King [this message]
2015-12-02 9:54 ` Mike Crowe
2015-12-02 9:56 ` [PATCH] push: Improve --recurse-submodules support Mike Crowe
2015-12-02 23:21 ` Junio C Hamano
2015-12-03 13:10 ` Mike Crowe
2015-12-03 13:10 ` [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config Mike Crowe
2015-12-03 13:10 ` [PATCH 2/2] push: Use "last one wins" convention for --recurse-submodules Mike Crowe
2015-12-04 21:04 ` Junio C Hamano
2015-12-10 23:31 ` Stefan Beller
2015-12-10 23:38 ` Junio C Hamano
2015-12-10 23:44 ` Stefan Beller
2015-12-16 20:48 ` [PATCH 1/2] push: Fully test --recurse-submodules on command line overrides config Stefan Beller
2015-12-16 22:41 ` Junio C Hamano
2015-12-16 22:46 ` Stefan Beller
2015-12-17 16:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202004031.GA28197@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=mac@mcrowe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).