* [PATCH] Fix quoting of redirect in test script
@ 2015-12-02 20:50 Charles Bailey
2015-12-04 21:05 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Charles Bailey @ 2015-12-02 20:50 UTC (permalink / raw)
To: git
From: Charles Bailey <cbailey32@bloomberg.net>
---
t/t3404-rebase-interactive.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
If you are using bash (at least 4.3.30 or 4.3.42) this actually causes
an error due to an "ambiguous redirect" because there is a space in
"trash directory".
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 98eb49a..9067e02 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -1234,7 +1234,7 @@ test_expect_success 'tabs and spaces are accepted in the todolist' '
# Turn single spaces into space/tab mix
sed "1s/ / /g; 2s/ / /g; 3s/ / /g" "$1"
printf "\n\t# comment\n #more\n\t # comment\n"
- ) >$1.new
+ ) >"$1.new"
mv "$1.new" "$1"
EOF
test_set_editor "$(pwd)/add-indent.sh" &&
--
2.4.0.53.g8440f74
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix quoting of redirect in test script
2015-12-02 20:50 [PATCH] Fix quoting of redirect in test script Charles Bailey
@ 2015-12-04 21:05 ` Junio C Hamano
2015-12-04 21:39 ` Charles Bailey
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2015-12-04 21:05 UTC (permalink / raw)
To: Charles Bailey; +Cc: git
Do you want to sign-off this patch?
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix quoting of redirect in test script
2015-12-04 21:05 ` Junio C Hamano
@ 2015-12-04 21:39 ` Charles Bailey
0 siblings, 0 replies; 3+ messages in thread
From: Charles Bailey @ 2015-12-04 21:39 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Fri, Dec 04, 2015 at 01:05:20PM -0800, Junio C Hamano wrote:
> Do you want to sign-off this patch?
>
> Thanks.
Oops, yes please.
Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-04 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-02 20:50 [PATCH] Fix quoting of redirect in test script Charles Bailey
2015-12-04 21:05 ` Junio C Hamano
2015-12-04 21:39 ` Charles Bailey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).