git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Hocevar <sam@hocevar.net>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Git Users <git@vger.kernel.org>, Luke Diamand <luke@diamand.org>,
	Pete Wyckoff <pw@padd.com>
Subject: Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit
Date: Mon, 7 Dec 2015 19:51:29 +0100	[thread overview]
Message-ID: <20151207185129.GA48528@hocevar.net> (raw)
In-Reply-To: <F328D5D9-754A-41CC-A7B2-993B9315ED33@gmail.com>

On Sun, Dec 06, 2015, Lars Schneider wrote:
> Thanks for the patch! Do you see a way to demonstrate the bug in a test case similar to t9821 [1]?

   Not yet, I'm afraid. It's proving trickier than expected because for
now I can only reproduce the bug when the view uses multiples depots
(solution #2 on http://answers.perforce.com/articles/KB/2437), and
unfortunately the test case system in Git was designed for a single
depot.

   Would a refactor of lib-git-p4.sh (and probably all git-p4 tests) to
support multiple depots be acceptable and/or welcome? I prefer to ask
before I dig into the task.

Regards,
-- 
Sam.

  reply	other threads:[~2015-12-07 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05 11:22 [PATCH 1/2] git-p4: support multiple depot paths in p4 submit Sam Hocevar
2015-12-06 11:56 ` Lars Schneider
2015-12-07 18:51   ` Sam Hocevar [this message]
2015-12-08  9:48     ` Lars Schneider
2015-12-08 11:41       ` Sam Hocevar
2015-12-08 12:32         ` Luke Diamand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151207185129.GA48528@hocevar.net \
    --to=sam@hocevar.net \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    --cc=pw@padd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).