git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: pedro rijo <pedrorijo91@gmail.com>, git@vger.kernel.org
Subject: Re: git format-patch on empty commit
Date: Mon, 11 Jan 2016 16:09:15 -0500	[thread overview]
Message-ID: <20160111210915.GA21173@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqegdnx1xx.fsf@gitster.mtv.corp.google.com>

On Mon, Jan 11, 2016 at 01:04:42PM -0800, Junio C Hamano wrote:

> So I think skipping no-op commit from the output was done pretty
> much deliberately and it is definitely not a bug.  I however do not
> think it is incorrect to say that it is a lack of feature that
> nobody so far found necessary or beneficial.
> 
> I would not refuse to consider adding a new option to "format-patch"
> to emit such a no-op message, and add a "having no patch is OK, just
> record a no-op commit" option to "am", though.  But I do not see a
> clear benefit from such change--it sounds more like a set of
> "because we could" not "because we need to" changes to me.

I think we are more or less on the same page. To me it is less "because
we could" but that some people seem to find empty commits useful in
their workflow (which is why we have "commit --allow-empty"), and if you
use such a workflow, it is probably reasonable for "format-patch | am"
or "rebase" to be trusted to preserve the history (at least with an
option).

I do not use such workflows myself[1], so I will leave open the question
of whether they have a benefit. :)

-Peff

[1] Though I will confess to finding "commit --allow-empty" quite useful
    when debugging.

  reply	other threads:[~2016-01-11 21:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 14:19 git format-patch on empty commit pedro rijo
2016-01-11 20:53 ` Jeff King
2016-01-11 21:04   ` Junio C Hamano
2016-01-11 21:09     ` Jeff King [this message]
2016-01-11 23:47     ` pedro rijo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160111210915.GA21173@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pedrorijo91@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).