From: Tobias Klauser <tklauser@distanz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <chriscool@tuxfamily.org>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Eric Sunshine <sunshine@sunshineco.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3 1/2] trailer: use fprintf instead of printf
Date: Thu, 14 Jan 2016 10:33:45 +0100 [thread overview]
Message-ID: <20160114093345.GG26950@distanz.ch> (raw)
In-Reply-To: <xmqqd1t5nv6j.fsf@gitster.mtv.corp.google.com>
On 2016-01-13 at 20:20:04 +0100, Junio C Hamano <gitster@pobox.com> wrote:
> Tobias Klauser <tklauser@distanz.ch> writes:
>
> > Use fprintf instead of printf in trailer.c in order to allow printing
> > to a file other than stdout. This will be needed to support in-place
> > editing in git interpret-trailers.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>
> Thanks. I won't bother to amend it myself or request you to reroll
> only for this, but that is a rather suboptimal title.
Agree.
> The distinction between fprintf/printf is an implementation detail;
> what you want to do in this change is to allow writing to a file
> other than the standard output, and that should be in the title.
Since I'll do a v4 anyhow to address Eric's review comments, I can
change the title in the reroll.
Thanks
next prev parent reply other threads:[~2016-01-14 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 12:43 [PATCH v3 0/2] Add in-place editing support to git interpret-trailers Tobias Klauser
2016-01-13 12:43 ` [PATCH v3 1/2] trailer: use fprintf instead of printf Tobias Klauser
2016-01-13 19:20 ` Junio C Hamano
2016-01-14 9:33 ` Tobias Klauser [this message]
2016-01-13 12:43 ` [PATCH v3 2/2] interpret-trailers: add option for in-place editing Tobias Klauser
2016-01-13 18:15 ` Eric Sunshine
2016-01-14 9:31 ` Tobias Klauser
2016-01-13 12:44 ` [PATCH v3 0/2] Add in-place editing support to git interpret-trailers Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114093345.GG26950@distanz.ch \
--to=tklauser@distanz.ch \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).