From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH v4 16/21] transport-helper: read helper response with strbuf_getline() Date: Fri, 15 Jan 2016 15:31:09 -0500 Message-ID: <20160115203108.GF11301@sigill.intra.peff.net> References: <1452740590-16827-1-git-send-email-gitster@pobox.com> <1452815916-6447-1-git-send-email-gitster@pobox.com> <1452815916-6447-17-git-send-email-gitster@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org, Johannes Schindelin To: Junio C Hamano X-From: git-owner@vger.kernel.org Fri Jan 15 21:31:17 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aKB1g-0000PV-3N for gcvg-git-2@plane.gmane.org; Fri, 15 Jan 2016 21:31:16 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbcAOUbM (ORCPT ); Fri, 15 Jan 2016 15:31:12 -0500 Received: from cloud.peff.net ([50.56.180.127]:54645 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751821AbcAOUbM (ORCPT ); Fri, 15 Jan 2016 15:31:12 -0500 Received: (qmail 10761 invoked by uid 102); 15 Jan 2016 20:31:11 -0000 Received: from Unknown (HELO peff.net) (10.0.1.1) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Fri, 15 Jan 2016 15:31:11 -0500 Received: (qmail 23564 invoked by uid 107); 15 Jan 2016 20:31:30 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Fri, 15 Jan 2016 15:31:30 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 15 Jan 2016 15:31:09 -0500 Content-Disposition: inline In-Reply-To: <1452815916-6447-17-git-send-email-gitster@pobox.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Jan 14, 2016 at 03:58:31PM -0800, Junio C Hamano wrote: > Our implementation of helpers never use CRLF line endings, and they > do not depend on the ability to place a CR as payload at the end of > the line, so this is essentially a no-op for in-tree users. However, > this allows third-party implementation of helpers to give us their > line with CRLF line ending (they cannot expect us to feed CRLF to > them, though). I think this is OK. I cannot think of any transport-helper request or response which wants to pass anything more exotic than a refname as its final argument. And if we were to add one, it would need to take care to quote its argument somehow to allow "\n" anyway. -Peff