From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 3/6] shortlog: replace hand-parsing of author with pretty-printer
Date: Mon, 18 Jan 2016 15:13:38 -0500 [thread overview]
Message-ID: <20160118201337.GA15943@sigill.intra.peff.net> (raw)
In-Reply-To: <20160118200248.GC15836@sigill.intra.peff.net>
On Mon, Jan 18, 2016 at 03:02:48PM -0500, Jeff King wrote:
> + format_commit_message(commit, "%an <%ae>", &author, &ctx);
> + /* we can detect a total failure only by seeing " <>" in the output */
> + if (author.len <= 3) {
> warning(_("Missing author: %s"),
> oid_to_hex(&commit->object.oid));
> [...]
> + goto out;
> }
One note on this. In the linux.git tree, this warning actually triggers,
because there is a commit with a bogus empty author:
$ git log -1 --format=raw af25e94d4dc | grep ^author
author <> 1120285620 -0700
Whereas in the original code, you really do get a line with a blank
name.
I think what the new code does is quite reasonable, but I'm not sure if:
1. People really want a syntactically valid empty name to be
represented.
and
2. Regardless of the output, if kernel folks will be annoyed by the
warning whenever they run a full-repo shortlog.
-Peff
next prev parent reply other threads:[~2016-01-18 20:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 17:06 [PATCH 0/6] shortlog fixes and optimizations Jeff King
2016-01-15 17:08 ` [PATCH 1/6] shortlog: match both "Author:" and "author" on stdin Jeff King
2016-01-15 23:19 ` Eric Sunshine
2016-01-18 19:27 ` Jeff King
2016-01-18 19:26 ` Jeff King
2016-01-18 19:55 ` Junio C Hamano
2016-01-18 20:01 ` [PATCH v2 0/6] shortlog fixes and optimizations Jeff King
2016-01-18 20:02 ` [PATCH 1/6] shortlog: match both "Author:" and "author" on stdin Jeff King
2016-01-18 20:02 ` [PATCH 2/6] shortlog: use strbufs to read from stdin Jeff King
2016-01-18 20:02 ` [PATCH 3/6] shortlog: replace hand-parsing of author with pretty-printer Jeff King
2016-01-18 20:13 ` Jeff King [this message]
2016-01-18 23:04 ` Jeff King
2016-01-19 3:47 ` Junio C Hamano
2016-01-18 20:02 ` [PATCH 4/6] shortlog: optimize "--summary" mode Jeff King
2016-01-18 20:02 ` [PATCH 5/6] shortlog: optimize out useless "<none>" normalization Jeff King
2016-01-18 20:02 ` [PATCH 6/6] shortlog: optimize out useless string list Jeff King
2016-01-15 17:08 ` [PATCH 2/6] shortlog: use strbufs to read from stdin Jeff King
2016-01-15 17:09 ` [PATCH 3/6] shortlog: replace hand-parsing of author with pretty-printer Jeff King
2016-01-15 17:09 ` [PATCH 4/6] shortlog: optimize "--summary" mode Jeff King
2016-01-15 17:10 ` [PATCH 5/6] shortlog: optimize out useless "<none>" normalization Jeff King
2016-01-15 17:10 ` [PATCH 6/6] shortlog: optimize out useless string list Jeff King
2016-01-15 22:11 ` [PATCH 0/6] shortlog fixes and optimizations Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118201337.GA15943@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).