From: Tobias Klauser <tklauser@distanz.ch>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Christian Couder <chriscool@tuxfamily.org>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] interpret-trailers: add option for in-place editing
Date: Tue, 19 Jan 2016 09:28:28 +0100 [thread overview]
Message-ID: <20160119082828.GE21205@distanz.ch> (raw)
In-Reply-To: <CAPig+cQ5X7r22pXyCs_n+-mXK3Lzh1CpAMQ_PbuhLT4C3S+v1Q@mail.gmail.com>
On 2016-01-18 at 23:13:22 +0100, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Mon, Jan 18, 2016 at 4:21 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > On Jan 18, 2016 13:11, "Eric Sunshine" <sunshine@sunshineco.com> wrote:
> >> On Thu, Jan 14, 2016 at 3:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
> >>> If for some reason interpret-trailers fails to fail, this would
> >>> leave an unreadable 'message' in the trash directory. Maybe no
> >>> other tests that come after this one want to be able to read the
> >>> contents of the file right now, but this is an accident waiting to
> >>> happen:
> >>>
> >>> cat basic_message >message &&
> >>> + test_when_finished "chmod +r message" &&
> >>> chmod -r message &&
> >>> test_must_fail ... &&
> >>> chmod +r message &&
> >>
> >> Don't forget to remove this (now unnecessary) "chmod +r" once you've
> >> added the 'test_when_finished "chmod +r"'.
> >>
> >>> test_cmp ...
> >
> > It still is necessary for the test-cmp to work, no?
>
> My bad. Ignore me.
>
> By the way, isn't the:
>
> cat basic_message >message &&
>
> in the above test just an unusual way to say:
>
> cp basic_message message &&
>
> ?
Yes. I was following the other test cases which use cat to build more
complex messages.
I can change this as well along with the 'test_when_finished' fix.
next prev parent reply other threads:[~2016-01-19 8:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 16:57 [PATCH v4 0/2] Add in-place editing support to git interpret-trailers Tobias Klauser
2016-01-14 16:57 ` [PATCH v4 1/2] trailer: allow to write to files other than stdout Tobias Klauser
2016-01-14 16:57 ` [PATCH v4 2/2] interpret-trailers: add option for in-place editing Tobias Klauser
2016-01-14 20:45 ` Junio C Hamano
2016-01-15 10:34 ` Tobias Klauser
2016-01-15 17:24 ` Junio C Hamano
2016-01-15 17:45 ` Tobias Klauser
2016-01-18 21:11 ` Eric Sunshine
[not found] ` <CAPc5daWpnReWJzeTJjvZap78H0oZKG-YGEP19Neusyahu5A6cQ@mail.gmail.com>
2016-01-18 22:13 ` Eric Sunshine
2016-01-19 8:28 ` Tobias Klauser [this message]
2016-01-19 17:52 ` Junio C Hamano
2016-01-19 17:56 ` Eric Sunshine
2016-01-19 18:10 ` Eric Sunshine
2016-01-19 20:58 ` Junio C Hamano
2016-01-19 21:45 ` Eric Sunshine
2016-01-19 22:09 ` Junio C Hamano
2016-01-20 0:20 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119082828.GE21205@distanz.ch \
--to=tklauser@distanz.ch \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).