From: Jeff King <peff@peff.net>
To: Matt Kraai <kraai@ftbfs.org>
Cc: git@vger.kernel.org, Philip Oakley <philipoakley@iee.org>,
Matthew Kraai <matt.kraai@abbott.com>
Subject: Re: [PATCH] Documentation: remove unnecessary backslashes
Date: Wed, 20 Jan 2016 13:24:21 -0500 [thread overview]
Message-ID: <20160120182421.GA27562@sigill.intra.peff.net> (raw)
In-Reply-To: <1453310497-7971-1-git-send-email-kraai@ftbfs.org>
On Wed, Jan 20, 2016 at 09:21:37AM -0800, Matt Kraai wrote:
> From: Matthew Kraai <matt.kraai@abbott.com>
>
> asciidoctor does not remove backslashes used to escape curly brackets from
> the HTML output if the contents of the curly brackets are empty or contain
> at least a <, -, or space. asciidoc does not require the backslashes in
> these cases, so just remove them.
I think these backslashes may have been necessary in older versions of
asciidoc, but I don't recall the details. Looks like we did a similar
round of cleanups already in 4538a88256, so this is probably safe (and I
verified with asciidoc 8.6.9 that the generated output is the same).
> -'<refname>@\{<date>\}', e.g. 'master@\{yesterday\}', 'HEAD@\{5 minutes ago\}'::
> +'<refname>@{<date>}', e.g. 'master@\{yesterday\}', 'HEAD@{5 minutes ago}'::
I see you didn't tweak the middle one here, because it _does_ look like
an attribute. Does asciidoctor actually remove the backslashes there?
> -'<refname>@\{<n>\}', e.g. 'master@\{1\}'::
> +'<refname>@{<n>}', e.g. 'master@\{1\}'::
Ditto here for "1". IMHO asciidoctor's behavior is somewhat crazy, as it
means you have to know arcane quoting rules to get correct output (you
cannot just err on the side of quoting). But it's probably still worth
working around.
-Peff
next prev parent reply other threads:[~2016-01-20 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:21 [PATCH] Documentation: remove unnecessary backslashes Matt Kraai
2016-01-20 18:24 ` Jeff King [this message]
2016-01-20 20:28 ` Junio C Hamano
2016-01-20 20:34 ` Jeff King
2016-01-22 2:46 ` brian m. carlson
2016-01-20 21:35 ` Matt Kraai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120182421.GA27562@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
--cc=matt.kraai@abbott.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).