From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH] Trick to force setup of a specific configured E-Mail per repo Date: Wed, 3 Feb 2016 00:22:10 -0500 Message-ID: <20160203052209.GA22336@sigill.intra.peff.net> References: <1454442861-4879-1-git-send-email-alonid@gmail.com> <20160203035648.GA20732@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Dan Aloni , Git Mailing List To: Duy Nguyen X-From: git-owner@vger.kernel.org Wed Feb 03 06:22:22 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aQptV-000114-88 for gcvg-git-2@plane.gmane.org; Wed, 03 Feb 2016 06:22:21 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbcBCFWP (ORCPT ); Wed, 3 Feb 2016 00:22:15 -0500 Received: from cloud.peff.net ([50.56.180.127]:36551 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750874AbcBCFWM (ORCPT ); Wed, 3 Feb 2016 00:22:12 -0500 Received: (qmail 2322 invoked by uid 102); 3 Feb 2016 05:22:12 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Wed, 03 Feb 2016 00:22:12 -0500 Received: (qmail 21234 invoked by uid 107); 3 Feb 2016 05:22:11 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Wed, 03 Feb 2016 00:22:11 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 03 Feb 2016 00:22:10 -0500 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Feb 03, 2016 at 12:19:20PM +0700, Duy Nguyen wrote: > On Wed, Feb 3, 2016 at 10:56 AM, Jeff King wrote: > > I find it disappointing that we go back to looking for magic sequences > > in the string. Could we perhaps do this more cleanly with a new config > > option? Like a "user.guessIdent" which defaults to true, but people can > > set to false. And without that, we do not do any automagic at all; we > > get the values from the GIT_COMMITTER_* environment or the > > user.{name,email} config variables, or we die(). > > > > I think that should allow your use case (and extend the same feature to > > user.name). It wouldn't work on older versions of git, but nor would > > your fix here (the only way to do that is to re-instate "(none)" as > > magical). > > Should we generalize this use case, i.e. define a list of > configuration variables that must be (re-)defined per-repo? Maybe not > worth it, I don't know. I can't think of any other variable that > should behave this way off the top of my head. That's an interesting thought, but I'm not sure how it would work. The ident variables are special in that people are often unhappy with the fallback. What would it mean for somebody to say "do not proceed if diff.renameLimit is not set", and where would we enforce that? -Peff