From: Jeff King <peff@peff.net>
To: Karl Moskowski <kmoskowski@me.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>, git@vger.kernel.org
Subject: Re: Bug: Branch Deletion Doesn't Clean Up
Date: Thu, 4 Feb 2016 02:55:00 -0500 [thread overview]
Message-ID: <20160204075500.GA21161@sigill.intra.peff.net> (raw)
In-Reply-To: <4AC354E1-9E78-42A8-9828-BF1C084A6CBB@me.com>
[resend; sorry, I forgot to cc Michael on the first one]
On Thu, Jan 07, 2016 at 02:24:41PM -0500, Karl Moskowski wrote:
> The problem is, deleting a branch whose name contains slashes doesn’t
> delete the directories in .git/refs/heads/.
Yes. Git's model is to leave the directories in place, and remove them
only when they get in the way of creating another ref. In theory, the
effect is the same as deleting the directories proactively.
But as you noticed, it does funny things with case-preserving
filesystems. It also can cause performance problems if you have a very
large number of empty directories (because git has to open each of them
just to find out they're empty).
We can into the latter case at GitHub. Michael Haggerty (cc'd) worked up
some patches recently for this, but I don't now if they're yet polished
enough to send upstream.
> It seems like git branch -d ascend the hierarchy (up to
> .git/refs/heads/), deleting any empty directories.
Yes, though it needs to be coupled with making the branch-creation
process more robust to races (since we might create "refs/heads/foo" in
order to make "refs/heads/foo/bar" while somebody else is deleting it to
get rid of "refs/heads/foo/baz").
-Peff
next prev parent reply other threads:[~2016-02-04 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 19:24 Bug: Branch Deletion Doesn't Clean Up Karl Moskowski
2016-02-04 7:54 ` Jeff King
2016-02-04 7:55 ` Jeff King [this message]
2016-02-04 8:12 ` Mike Hommey
2016-02-04 8:17 ` Jeff King
2016-02-04 8:26 ` Mike Hommey
2016-02-04 8:29 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204075500.GA21161@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kmoskowski@me.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).