From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Kirill Likhodedov <kirill.likhodedov@jetbrains.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git <git@vger.kernel.org>
Subject: Re: git show doesn't work on file names with square brackets
Date: Mon, 8 Feb 2016 09:24:40 -0500 [thread overview]
Message-ID: <20160208142439.GA8262@sigill.intra.peff.net> (raw)
In-Reply-To: <20160208141552.GC27054@sigill.intra.peff.net>
On Mon, Feb 08, 2016 at 09:15:52AM -0500, Jeff King wrote:
> I wonder if we could fix this pretty simply, though, by skipping the
> "does it have a wildcard" check when we see a colon in the path. That is
> a good indication that we are using one of git's special rev syntaxes
> (either "tree:path", or ":path", or ":/search string". That breaks
> anybody who really wanted to look for "path:with:colons.*", but that
> seems a lot less likely to me.
Actually, I guess:
:/foo
does have a meaning as a pathspec (though again, this is only about
limiting the wildcard case, so I think that's OK). More worrisome would
be:
:(literal)[brackets]
which is almost certainly a pathspec.
So I guess I would revise my suggestion to: we could probably do a lot
better (but not perfectly, of course) by guessing at basic syntactic
components.
-Peff
next prev parent reply other threads:[~2016-02-08 14:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 13:16 git show doesn't work on file names with square brackets Kirill Likhodedov
2016-02-06 14:21 ` Johannes Schindelin
2016-02-06 14:29 ` Kirill Likhodedov
2016-02-06 16:10 ` Johannes Schindelin
2016-02-06 23:48 ` Duy Nguyen
2016-02-07 15:11 ` Kirill Likhodedov
2016-02-08 5:06 ` Duy Nguyen
2016-02-08 14:15 ` Jeff King
2016-02-08 14:24 ` Jeff King [this message]
2016-02-08 15:07 ` Jeff King
2016-02-08 19:35 ` Junio C Hamano
2016-02-08 19:52 ` Jeff King
2016-02-08 20:20 ` Jeff King
2016-02-08 20:56 ` Jeff King
2016-02-08 22:36 ` Junio C Hamano
2016-02-10 15:45 ` Jeff King
2016-02-09 20:37 ` Junio C Hamano
2016-02-10 16:15 ` Jeff King
2016-02-10 17:35 ` Junio C Hamano
2016-02-10 21:12 ` Jeff King
2016-02-10 21:12 ` [PATCH 1/3] checkout: reorder check_filename conditional Jeff King
2016-02-10 21:31 ` Junio C Hamano
2016-02-10 21:14 ` [PATCH 2/3] check_filename: tighten dwim-wildcard ambiguity Jeff King
2016-02-10 21:19 ` [PATCH 3/3] get_sha1: don't die() on bogus search strings Jeff King
2016-02-10 21:52 ` Junio C Hamano
2016-02-07 15:09 ` git show doesn't work on file names with square brackets Kirill Likhodedov
2016-02-07 17:10 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208142439.GA8262@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kirill.likhodedov@jetbrains.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).