From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Markus Kuhn <Markus.Kuhn@cl.cam.ac.uk>, Git List <git@vger.kernel.org>
Subject: Re: man git-config inconsistency (*.fsckObjects)
Date: Mon, 8 Feb 2016 13:41:10 -0500 [thread overview]
Message-ID: <20160208184109.GA29332@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cQZ2LWsy1VC7Aqm+V3cWG7Y3rb0dGfyS_c3BCVM3Dekgw@mail.gmail.com>
On Mon, Feb 08, 2016 at 01:00:50PM -0500, Eric Sunshine wrote:
> On Mon, Feb 8, 2016 at 10:08 AM, Jeff King <peff@peff.net> wrote:
> > On Mon, Feb 08, 2016 at 02:41:44PM +0000, Markus Kuhn wrote:
> >> Suggested rephrasing:
> >>
> >> If not set, the value of transfer.fsckObjects is used
> >> instead, which defaults to false.
> >
> > Yeah, I agree your phrasing is much clearer.
>
> Should we worry about this becoming outdated if the default of
> transfer.fsckObjects ever changes, or is that being overcautious? If
> it is a legitimate concern, then perhaps drop "which defaults to
> false" from the end of the sentence.
I agree that is a potential maintenance pitfall, but I think it is
outweighed by the benefit: namely that the information the user wants is
right there, without them having to cross-reference themselves.
Flipping the default for transfer.fsckObjects would hopefully cause us
to examine matching fetch.*, and we would notice this during review.
-Peff
prev parent reply other threads:[~2016-02-08 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 14:41 man git-config inconsistency (*.fsckObjects) Markus Kuhn
2016-02-08 15:08 ` Jeff King
2016-02-08 18:00 ` Eric Sunshine
2016-02-08 18:41 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208184109.GA29332@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Markus.Kuhn@cl.cam.ac.uk \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).