From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh
Date: Mon, 8 Feb 2016 14:35:09 -0500 [thread overview]
Message-ID: <20160208193509.GA30554@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1602082027550.2964@virtualbox>
On Mon, Feb 08, 2016 at 08:31:54PM +0100, Johannes Schindelin wrote:
> On Mon, 8 Feb 2016, Jeff King wrote:
>
> > Assuming your patch works on Windows
>
> If it re-introduces that chmod +x, it won't.
>
> Please note that my *original* patch actually only guarded the chmod +x,
> but Junio suggested switching to write_script and since it passed the test
> suite here, I though it would be safe.
>
> I still think write_script is the better alternative.
I'm confused why it matters. write_script() unconditionally calls "chmod
+x", doesn't it?
I just double-checked its definition in test-lib-function.sh; am I
missing some Windows-specific magic that kicks in?
> So why not just prefix it with `SHELL_PATH=/bin/sh`?
But then what is write_script buying us?
-Peff
next prev parent reply other threads:[~2016-02-08 19:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 19:11 [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh Michael J Gruber
2016-02-08 13:50 ` Jeff King
2016-02-08 16:34 ` Michael J Gruber
[not found] ` <CAA19uiRSu_6Os3b498obSNec7b2uiYv20SZ=y93CkjsWqhqHzA@mail.gmail.com>
2016-02-08 16:37 ` Jeff King
2016-02-08 19:31 ` Johannes Schindelin
2016-02-08 19:35 ` Jeff King [this message]
2016-02-08 19:43 ` Junio C Hamano
2016-02-08 19:56 ` Jeff King
2016-02-09 10:00 ` Johannes Schindelin
2016-02-09 17:30 ` Junio C Hamano
2016-02-08 19:59 ` Johannes Schindelin
2016-02-08 20:12 ` Junio C Hamano
2016-02-09 10:07 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208193509.GA30554@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).