From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org
Subject: Re: [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh
Date: Mon, 8 Feb 2016 14:56:30 -0500 [thread overview]
Message-ID: <20160208195630.GB30693@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqlh6v7zu0.fsf@gitster.mtv.corp.google.com>
On Mon, Feb 08, 2016 at 11:43:19AM -0800, Junio C Hamano wrote:
> > But then what is write_script buying us?
>
> The correct way to write a script for a specific interpreter is to
> give a second parameter to write_script, i.e.
>
> write_script exec.sh /bin/sh </dev/null &&
>
> and the answer to the question is "it will save us one line".
At the cost of a useless "cat" invocation, though. :)
> The version in 'master' that does
>
> echo "#!/bin/sh" >exec.sh &&
> chmod +x exec.sh &&
>
> should be equivalent, so dropping that hunk from the patch is the
> right resolution perhaps?
Yeah, but I still don't understand why the original did not work on
Windows, once all the other hunks from bcb11f1 are applied.
-Peff
next prev parent reply other threads:[~2016-02-08 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 19:11 [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh Michael J Gruber
2016-02-08 13:50 ` Jeff King
2016-02-08 16:34 ` Michael J Gruber
[not found] ` <CAA19uiRSu_6Os3b498obSNec7b2uiYv20SZ=y93CkjsWqhqHzA@mail.gmail.com>
2016-02-08 16:37 ` Jeff King
2016-02-08 19:31 ` Johannes Schindelin
2016-02-08 19:35 ` Jeff King
2016-02-08 19:43 ` Junio C Hamano
2016-02-08 19:56 ` Jeff King [this message]
2016-02-09 10:00 ` Johannes Schindelin
2016-02-09 17:30 ` Junio C Hamano
2016-02-08 19:59 ` Johannes Schindelin
2016-02-08 20:12 ` Junio C Hamano
2016-02-09 10:07 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208195630.GB30693@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).