From: Jeff King <peff@peff.net>
To: Shawn Pearce <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] remote-curl: Include curl_errorstr on SSL setup failures
Date: Sun, 14 Feb 2016 11:50:48 -0500 [thread overview]
Message-ID: <20160214165048.GA10219@sigill.intra.peff.net> (raw)
In-Reply-To: <1455413974-25147-1-git-send-email-spearce@spearce.org>
On Sat, Feb 13, 2016 at 05:39:34PM -0800, Shawn Pearce wrote:
> For curl error 35 (CURLE_SSL_CONNECT_ERROR) users need the
> additional text stored in CURLOPT_ERRORBUFFER to debug why
> the connection did not start. This is curl_errorstr inside
> of http.c, so include that in the message if it is non-empty.
I think this is an all-around improvement. GitHub sometimes get support
requests for result=18 on a git-push, which is curl's code for "I dunno,
the remote end hung up". Having a human-readable message may make things
less confusing.
Unfortunately I cannot seem to create the problem at will to confirm
that it kicks in in this case[1], but it seems like it should just based on
reading your patch.
-Peff
[1] I tried inserting "exit(0)" in various places of receive-pack, and
it seems make the protocol deadlock. Yikes.
next prev parent reply other threads:[~2016-02-14 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 1:39 [PATCH] remote-curl: Include curl_errorstr on SSL setup failures Shawn Pearce
2016-02-14 16:50 ` Jeff King [this message]
2016-02-14 18:04 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214165048.GA10219@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).