Issues with cc-cmd

Issues with cc-cmd

[Viresh Kumar]

Hi Guys,

I am facing a strange issue with git send-email, with cccmd and was
looking for some help.

I am using it with Linux Kernel..

I used get-maintainers today to submit few patches for OPP framework
and that is defined as below in MAINTAINERS:

OPERATING PERFORMANCE POINTS (OPP)
M:      Viresh Kumar <vireshk@kernel.org>
M:      Nishanth Menon <nm@ti.com>
M:      Stephen Boyd <sboyd@codeaurora.org>
L:      linux-pm@vger.kernel.org
S:      Maintained
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git
F:      drivers/base/power/opp/
F:      include/linux/pm_opp.h
F:      Documentation/power/opp.txt
F:      Documentation/devicetree/bindings/opp/


The parenthesis in the subsystem-name causes the cc list to look like:

Cc: linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org (open list),
linux-pm@vger.kernel.org) (open list:OPERATING PERFORMANCE POINTS
(OPP),
Nishanth Menon <nm@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Stephen Boyd <sboyd@codeaurora.org>,
Viresh Kumar <vireshk@kernel.org>


Look at the second linux-pm entry here, it adds a ')' at the end of
the list's address and removes it from the end of the line.

And so that becomes an invalid address to git-send-email.

Dropping () from the subsystem name fixes it though..

The output of get_maintainers looks fine, but when its being used by
putting following into .gitconfig:

[sendemail]
        cccmd = scripts/get_maintainers


it doesn't work well..

-- 
viresh

Re: Issues with cc-cmd

[Junio C Hamano]

Viresh Kumar <viresh.kumar@linaro.org> writes:

> linux-pm@vger.kernel.org) (open list:OPERATING PERFORMANCE POINTS
> (OPP),

Hmm

http://lists.kernelnewbies.org/pipermail/kernelnewbies/2014-July/011343.html

comes to mind.  It tells you not to blindly automate this process.

I do not offhand know if it was even designed to be directly used
(and usable) as a cccmd, but anyway, I see this mention in its
"Notes:" section:

  Using "--roles" or "--rolestats" with git send-email --cc-cmd or any
      other automated tools that expect only ["name"] <email address>
      may not work because of additional output after <email address>.

I suspect that what you are showing is the "additional output after
address" the above talks about.

In any case, this command is maintained as part of the kernel, no?
I see Joe Perches signed at the beginning of file in 2007; I do not
know if he still maintains this script, or somebody else is
primarily enhancing it these days (ehh, I probably could use the
script on itself, but I am way too lazy late at night), but asking
him would be a good starting point, instead of asking here.

Re: Issues with cc-cmd

[Viresh Kumar]

On 15-02-16, 02:06, Junio C Hamano wrote:
> Viresh Kumar <viresh.kumar@linaro.org> writes:
> 
> > linux-pm@vger.kernel.org) (open list:OPERATING PERFORMANCE POINTS
> > (OPP),
> 
> Hmm
> 
> http://lists.kernelnewbies.org/pipermail/kernelnewbies/2014-July/011343.html
> 
> comes to mind.  It tells you not to blindly automate this process.
> 
> I do not offhand know if it was even designed to be directly used
> (and usable) as a cccmd, but anyway, I see this mention in its
> "Notes:" section:
> 
>   Using "--roles" or "--rolestats" with git send-email --cc-cmd or any
>       other automated tools that expect only ["name"] <email address>
>       may not work because of additional output after <email address>.
> 
> I suspect that what you are showing is the "additional output after
> address" the above talks about.
> 
> In any case, this command is maintained as part of the kernel, no?
> I see Joe Perches signed at the beginning of file in 2007; I do not
> know if he still maintains this script, or somebody else is
> primarily enhancing it these days (ehh, I probably could use the
> script on itself, but I am way too lazy late at night), but asking
> him would be a good starting point, instead of asking here.

Yeah, he told me this sometime back and that solved the issues I was
facing, and in fact it looks far better now. Thanks Junio.

git send-email requires a simple list of names and addresses
without decorations like roles, commit stats or section names.

You are supposed to use something like:

tocmd = "scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --pattern-depth=1 --nol"
cccmd = "scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nom --nor"

-- 
viresh