From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/4] remote: use skip_prefix
Date: Mon, 15 Feb 2016 13:36:22 -0500 [thread overview]
Message-ID: <20160215183622.GA27244@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cSkfEwa8TTJPg5B9W8FCqPXD9Uz6_EuFQeriwYHhP99gg@mail.gmail.com>
On Mon, Feb 15, 2016 at 01:35:03PM -0500, Eric Sunshine wrote:
> On Mon, Feb 15, 2016 at 1:18 PM, Jeff King <peff@peff.net> wrote:
> > This is definitely an improvement, but I think we can actually go a step
> > further here, and use parse_config_key. Like:
> >
> > - if (starts_with(key, "branch.")) {
> > - name = key + 7;
> > - subkey = strrchr(name, '.');
> > - if (!subkey)
> > + if (starts_with(key, "branch", &name, &namelen, &subkey)) {
>
> I guess you meant: s/starts_with/parse_config_key/
Whoops, yeah. I'll belatedly add a "not even compile-tested" disclaimer.
:)
-Peff
next prev parent reply other threads:[~2016-02-15 18:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 17:42 [PATCH 0/4] git remote improvements Thomas Gummerer
2016-02-15 17:42 ` [PATCH 1/4] remote: use skip_prefix Thomas Gummerer
2016-02-15 18:18 ` Jeff King
2016-02-15 18:35 ` Eric Sunshine
2016-02-15 18:36 ` Jeff King [this message]
2016-02-15 20:37 ` Thomas Gummerer
2016-02-15 17:42 ` [PATCH 2/4] remote: simplify remote_is_configured() Thomas Gummerer
2016-02-15 18:21 ` Jeff King
2016-02-15 20:38 ` Thomas Gummerer
2016-02-15 21:37 ` Junio C Hamano
2016-02-15 17:42 ` [PATCH 3/4] remote: actually check if remote exits Thomas Gummerer
2016-02-15 18:23 ` Jeff King
2016-02-15 17:42 ` [PATCH 4/4] remote: use remote_is_configured() for add and rename Thomas Gummerer
2016-02-15 18:33 ` Jeff King
2016-02-15 20:43 ` Thomas Gummerer
2016-02-17 13:54 ` Johannes Schindelin
2016-02-17 14:24 ` Thomas Gummerer
2016-02-17 16:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215183622.GA27244@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).