From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Paul Tan <pyokagan@gmail.com>
Subject: Re: [PATCH v2 0/3] fix "v"iew subcommand in "git am -i"
Date: Wed, 17 Feb 2016 14:19:24 -0500 [thread overview]
Message-ID: <20160217191923.GA16265@sigill.intra.peff.net> (raw)
In-Reply-To: <1455736516-13466-1-git-send-email-gitster@pobox.com>
On Wed, Feb 17, 2016 at 11:15:13AM -0800, Junio C Hamano wrote:
> So the first patch in this series factors out a helper function to
> let the caller run the pager the right way. They make the third
> patch to fix the breakage in "am" trivial. Compared to v1, the
> helper was much simplified with help by Peff: it always and only
> takes child-process and the pager command string. The caller can
> append extra command line arguments after the helper returns if it
> wants to.
>
> Junio C Hamano (3):
> pager: lose a separate argv[]
> pager: factor out a helper to prepare a child process to run the pager
> am -i: fix "v"iew
>
> builtin/am.c | 2 +-
> cache.h | 3 +++
> pager.c | 19 +++++++++++--------
> 3 files changed, 15 insertions(+), 9 deletions(-)
The whole thing looks good to me.
-Peff
prev parent reply other threads:[~2016-02-17 19:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 23:06 [PATCH 0/3] fix "v"iew subcommand in "git am -i" Junio C Hamano
2016-02-16 23:06 ` [PATCH 1/3] pager: lose a separate argv[] Junio C Hamano
2016-02-16 23:06 ` [PATCH 2/3] pager: factor out a helper to prepare a child process to run the pager Junio C Hamano
2016-02-16 23:26 ` Jeff King
2016-02-16 23:49 ` Junio C Hamano
2016-02-17 0:32 ` Jeff King
2016-02-16 23:06 ` [PATCH 3/3] am -i: fix "v"iew Junio C Hamano
2016-02-17 19:15 ` [PATCH v2 0/3] fix "v"iew subcommand in "git am -i" Junio C Hamano
2016-02-17 19:15 ` [PATCH v2 1/3] pager: lose a separate argv[] Junio C Hamano
2016-02-17 19:15 ` [PATCH v2 2/3] pager: factor out a helper to prepare a child process to run the pager Junio C Hamano
2016-02-17 19:15 ` [PATCH v2 3/3] am -i: fix "v"iew Junio C Hamano
2016-02-17 19:19 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217191923.GA16265@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).